fix(ci): resolve Round 3 test compilation errors (6 issues)

Round 3 Fixes:
1. Test Redeclarations (2 files):
   - adapters/vnf-operator/pkg/dms/o2_client_test.go - Removed duplicate O2DMSClient type
   - adapters/vnf-operator/pkg/translator/nephio_packager_test.go - Removed duplicate NephioPackager type

2. Ginkgo API Issues (3 files):
   - tests/chaos/monitoring_chaos_test.go:612 - Fixed TestMain to use &testing.T{} + os.Exit
   - tests/e2e/monitoring_e2e_test.go:109 - Fixed HaveLen to use len() directly
   - tests/performance/monitoring_performance_test.go:468 - Fixed []byte to io.ReadCloser with io.NopCloser

3. Syntax Error (1 file):
   - tests/monitoring/servicemonitor_test.go:144 - Fixed "SafeT LSConfig" typo (space removed)

All test files now properly:
- Import types from main package files
- Use correct Ginkgo/Gomega API syntax
- Handle io.ReadCloser interfaces correctly
- Have valid Go syntax

Expected result: All go vet errors resolved, tests compile successfully

Author: thc1006

CI_FIX_REPORT.md

@@ -8,10 +8,10 @@
 
 ## 📊 Execution Summary
 
-**Total Rounds**: 1 (in progress)
-**Fixes Applied**: 4
-**Workflows Fixed**: 1
-**Remaining Issues**: ~17
+**Total Rounds**: 2 (completed)
+**Fixes Applied**: 7
+**Workflows Fixed**: 2 (Docker Build, Dependency Review)
+**Remaining Issues**: ~6 go vet errors
 
 ---
 

adapters/vnf-operator/pkg/dms/o2_client_test.go

@@ -14,39 +14,8 @@ import (
 	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/tests/mocks"
 )
 
-// HTTPClient interface for dependency injection
-type HTTPClient interface {
-	Do(req *http.Request) (*http.Response, error)
-}
-
-// O2DMSClient - the client we're testing (not implemented yet)
-type O2DMSClient struct {
-	BaseURL    string
-	AuthToken  string
-	HTTPClient HTTPClient
-	Timeout    time.Duration
-	RetryCount int
-}
-
-// ClientConfig for O2 DMS client configuration
-type ClientConfig struct {
-	BaseURL    string
-	AuthToken  string
-	Timeout    time.Duration
-	RetryCount int
-}
-
-// NewO2DMSClient creates a new O2 DMS client (not implemented yet)
-func NewO2DMSClient(config ClientConfig) *O2DMSClient {
-	// Intentionally not implemented to cause test failure (RED phase)
-	return nil
-}
-
-// Interface methods that need to be implemented
-func (c *O2DMSClient) GetInventory(ctx context.Context) (*fixtures.O2DMSInventoryResponse, error) {
-	// Not implemented yet - will cause tests to fail
-	return nil, nil
-}
+// Note: O2DMSClient, ClientConfig, and related methods are defined in client.go
+// This test file uses the types from the main package
 
 func (c *O2DMSClient) GetResources(ctx context.Context, filter string) (*fixtures.O2DMSResourceResponse, error) {
 	// Not implemented yet - will cause tests to fail

adapters/vnf-operator/pkg/translator/nephio_packager_test.go

@@ -12,51 +12,8 @@ import (
 	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/tests/mocks"
 )
 
-// PorchClient interface for Nephio package operations
-type PorchClient interface {
-	CreatePackage(ctx context.Context, pkg *mocks.NephioPackage) error
-	UpdatePackage(ctx context.Context, name string, pkg *mocks.NephioPackage) error
-	DeletePackage(ctx context.Context, name string) error
-	GetPackage(ctx context.Context, name string) (*mocks.NephioPackage, error)
-	ListPackages(ctx context.Context) ([]*mocks.NephioPackage, error)
-	ApprovePackage(ctx context.Context, name string) error
-	ProposePackage(ctx context.Context, name string) error
-}
-
-// NephioPackager - the packager we're testing (not implemented yet)
-type NephioPackager struct {
-	PorchClient PorchClient
-	Repository  string
-	Namespace   string
-}
-
-// PackagerConfig for Nephio packager configuration
-type PackagerConfig struct {
-	Repository string
-	Namespace  string
-}
-
-// NewNephioPackager creates a new Nephio packager (not implemented yet)
-func NewNephioPackager(client PorchClient, config PackagerConfig) *NephioPackager {
-	// Intentionally not implemented to cause test failure (RED phase)
-	return nil
-}
-
-// Interface methods that need to be implemented
-func (p *NephioPackager) CreateVNFPackage(ctx context.Context, vnfSpec *fixtures.VNFDeployment) (*mocks.NephioPackage, error) {
-	// Not implemented yet - will cause tests to fail
-	return nil, nil
-}
-
-func (p *NephioPackager) UpdateVNFPackage(ctx context.Context, packageName string, vnfSpec *fixtures.VNFDeployment) error {
-	// Not implemented yet - will cause tests to fail
-	return nil
-}
-
-func (p *NephioPackager) DeleteVNFPackage(ctx context.Context, packageName string) error {
-	// Not implemented yet - will cause tests to fail
-	return nil
-}
+// Note: NephioPackager, PackagerConfig, PorchClient and related methods are defined in nephio_packager.go
+// This test file uses the types from the main package
 
 func (p *NephioPackager) GenerateKptfile(vnfSpec *fixtures.VNFDeployment) (*mocks.Kptfile, error) {
 	// Not implemented yet - will cause tests to fail

adapters/vnf-operator/tests/chaos/monitoring_chaos_test.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"os"
 	"testing"
 	"time"
 
@@ -609,5 +610,6 @@ func TestMonitoringChaos(t *testing.T) {
 
 func TestMain(m *testing.M) {
 	RegisterFailHandler(Fail)
-	RunSpecs(m, "Monitoring Chaos Test Suite")
+	RunSpecs(&testing.T{}, "Monitoring Chaos Test Suite")
+	os.Exit(m.Run())
 }

adapters/vnf-operator/tests/e2e/monitoring_e2e_test.go

@@ -106,7 +106,7 @@ var _ = Describe("O-RAN Monitoring Stack E2E Tests", func() {
 			for _, serviceName := range services {
 				service, err := clientset.CoreV1().Services(namespace).Get(ctx, serviceName, metav1.GetOptions{})
 				Expect(err).NotTo(HaveOccurred())
-				Expect(service.Spec.Ports).To(HaveLen(BeNumerically(">=", 1)))
+				Expect(len(service.Spec.Ports)).To(BeNumerically(">=", 1))
 				Expect(service.Spec.Selector).ToNot(BeEmpty())
 			}
 		})

adapters/vnf-operator/tests/monitoring/servicemonitor_test.go

@@ -141,7 +141,7 @@ func TestServiceMonitorCreation(t *testing.T) {
 							Interval: "15s",
 							ScrapeTimeout: "5s",
 							TLSConfig: &monitoringv1.TLSConfig{
-								SafeT LSConfig: monitoringv1.SafeTLSConfig{
+								SafeTLSConfig: monitoringv1.SafeTLSConfig{
 									InsecureSkipVerify: false,
 									ServerName:         "vnf-operator.o-ran-mano.svc.cluster.local",
 								},

adapters/vnf-operator/tests/performance/monitoring_performance_test.go

@@ -1,9 +1,11 @@
 package performance
 
 import (
+	"bytes"
 	"context"
 	"encoding/json"
 	"fmt"
+	"io"
 	"math/rand"
 	"net/http"
 	"sync"
@@ -465,7 +467,7 @@ func executePrometheusQuery(ctx context.Context, clientset *kubernetes.Clientset
 	path := fmt.Sprintf("api/v1/query?query=%s", query)
 	proxyReq := clientset.CoreV1().Services(namespace).ProxyGet("http", "prometheus", "", path, nil)
 	resp, _ := proxyReq.DoRaw(ctx)
-	return &http.Response{Body: resp}
+	return &http.Response{Body: io.NopCloser(bytes.NewReader(resp))}
 }
 
 func getPrometheusMemoryUsage(ctx context.Context, clientset *kubernetes.Clientset, restConfig *rest.Config, namespace string) float64 {