fix(tests): Round 16 - Fix 5 CI/CD Pipeline errors

Fixed all remaining CI/CD pipeline compilation errors:

1. tests/fixtures/placement_fixtures.go:
   - Fixed eMBBVNFDeployment → EMBBVNFDeployment (capitalization)
   - Function exists but was called with incorrect casing

2. adapters/vnf-operator/tests/e2e/monitoring_e2e_test.go:
   - Fixed makeClusterRequest return type
   - DoRaw() returns ([]byte, error) not (*http.Response, error)

3. adapters/vnf-operator/tests/monitoring/prometheus_deployment_test.go:
   - Renamed TestServiceMonitorCreation → TestPrometheusServiceMonitorCreation
   - Resolves duplicate test function name conflict

4. tn/agent/pkg/iperf_test.go:
   - Fixed IperfManager field name: mutex → mu
   - Also changed pointer to value type: sync.RWMutex{} not &sync.RWMutex{}

5. o2-client/pkg/o2dms/enhanced_client.go & o2ims/enhanced_client.go:
   - Removed dependency on pkg/logging (separate module)
   - Replaced logging.* calls with standard log.Println
   - Ensures o2-client module independence

All CI/CD Pipeline errors now resolved.

Resolves: Docker Build, CodeQL, and CI/CD Pipeline workflow failures

Author: thc1006

adapters/vnf-operator/tests/e2e/monitoring_e2e_test.go

@@ -544,7 +544,7 @@ func (suite *MonitoringE2ETestSuite) verifyMetricsFlow(t *testing.T) {
 
 // Helper function to make requests within the cluster
 func makeClusterRequest(ctx context.Context, clientset *kubernetes.Clientset, restConfig *rest.Config,
-	namespace, serviceName, path string) (*http.Response, error) {
+	namespace, serviceName, path string) ([]byte, error) {
 
 	// Create a proxy request to the service
 	proxyReq := clientset.CoreV1().Services(namespace).ProxyGet("http", serviceName, "", path, nil)

adapters/vnf-operator/tests/monitoring/prometheus_deployment_test.go

@@ -157,8 +157,8 @@ func TestPrometheusOperatorInstallation(t *testing.T) {
 	}
 }
 
-// TestServiceMonitorCreation tests ServiceMonitor creation for O-RAN components
-func TestServiceMonitorCreation(t *testing.T) {
+// TestPrometheusServiceMonitorCreation tests ServiceMonitor creation for O-RAN components with Prometheus
+func TestPrometheusServiceMonitorCreation(t *testing.T) {
 	testCases := []struct {
 		name           string
 		component      string

o2-client/pkg/o2dms/enhanced_client.go

@@ -3,13 +3,13 @@ package o2dms
 import (
 	"context"
 	"fmt"
+	"log"
 	"math"
 	"math/rand"
 	"sync"
 	"time"
 
 	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/o2-client/pkg/models"
-	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/pkg/logging"
 )
 
 // Enhanced O2 DMS Client with retry logic, event notifications, and advanced features
@@ -189,7 +189,7 @@ func (c *EnhancedClient) DeleteNFDeploymentWithRetry(ctx context.Context, deploy
 
 // DeployNetworkSlice deploys a complete network slice with multiple NFs
 func (c *EnhancedClient) DeployNetworkSlice(ctx context.Context, deploymentManagerID string, sliceSpec *NetworkSliceSpec) (*NetworkSliceDeployment, error) {
-	logging.Info("deploying network slice",
+	log.Println("deploying network slice",
 		"slice_id", sliceSpec.SliceID,
 		"deployment_manager_id", deploymentManagerID,
 		"nf_count", len(sliceSpec.NetworkFunctions))
@@ -270,7 +270,7 @@ func (c *EnhancedClient) WaitForDeploymentReadyWithRetry(ctx context.Context, de
 		var err error
 		lastDeployment, err = c.GetNFDeploymentWithRetry(ctx, deploymentManagerID, deploymentID)
 		if err != nil {
-			logging.Debug("failed to get deployment status",
+			log.Println("failed to get deployment status",
 				"deployment_id", deploymentID,
 				"deployment_manager_id", deploymentManagerID,
 				"error", err)
@@ -368,7 +368,7 @@ func (c *EnhancedClient) publishEvent(event Event) {
 	select {
 	case c.eventChan <- event:
 	default:
-		logging.Warn("event channel full, dropping event",
+		log.Println("event channel full, dropping event",
 			"event_id", event.ID,
 			"event_type", event.Type)
 	}
@@ -384,7 +384,7 @@ func (c *EnhancedClient) processEvent(event Event) {
 		go func(h EventHandler) {
 			defer func() {
 				if r := recover(); r != nil {
-					logging.Error("event handler panic",
+					log.Println("event handler panic",
 						"panic", r,
 						"event_id", event.ID,
 						"event_type", event.Type)
@@ -517,7 +517,7 @@ func (c *EnhancedClient) retryWithBackoff(ctx context.Context, fn func() error)
 				return err
 			}
 
-			logging.Debug("retry attempt",
+			log.Println("retry attempt",
 				"attempt", attempt+1,
 				"max_retries", c.retryConfig.MaxRetries,
 				"error", err)

o2-client/pkg/o2ims/enhanced_client.go

@@ -8,7 +8,7 @@ import (
 	"time"
 
 	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/o2-client/pkg/models"
-	"github.com/thc1006/O-RAN-Intent-MANO-for-Network-Slicing/pkg/logging"
+	"log"
 )
 
 // Enhanced O2 IMS Client Methods with retry logic and event handling
@@ -62,7 +62,7 @@ func (c *Client) publishEvent(event Event) {
 	select {
 	case c.eventChan <- event:
 	default:
-		logging.Warn("event channel full, dropping event",
+		log.Println("event channel full, dropping event",
 			"event_id", event.ID,
 			"event_type", event.Type)
 	}
@@ -78,7 +78,7 @@ func (c *Client) processEvent(event Event) {
 		go func(h EventHandler) {
 			defer func() {
 				if r := recover(); r != nil {
-					logging.Error("event handler panic",
+					log.Println("event handler panic",
 						"panic", r,
 						"event_id", event.ID,
 						"event_type", event.Type)
@@ -168,7 +168,7 @@ func (c *Client) performHealthCheck(ctx context.Context) {
 
 	_, err := c.GetHealthInfo(healthCtx)
 	if err != nil {
-		logging.Error("health check failed",
+		log.Println("health check failed",
 			"source", "o2ims.client",
 			"error", err)
 		c.publishEvent(Event{
@@ -180,7 +180,7 @@ func (c *Client) performHealthCheck(ctx context.Context) {
 			Severity:  SeverityError,
 		})
 	} else {
-		logging.Info("health check successful",
+		log.Println("health check successful",
 			"source", "o2ims.client")
 		c.publishEvent(Event{
 			ID:        fmt.Sprintf("health_%d", time.Now().UnixNano()),
@@ -280,7 +280,7 @@ func (c *Client) retryWithBackoff(ctx context.Context, fn func() error) error {
 				return err
 			}
 
-			logging.Debug("retry attempt",
+			log.Println("retry attempt",
 				"attempt", attempt+1,
 				"max_retries", c.retryConfig.MaxRetries,
 				"error", err)
@@ -333,7 +333,7 @@ func (c *Client) DiscoverResourcesByCapabilities(ctx context.Context, capabiliti
 	for _, pool := range pools.Items {
 		resources, err := c.GetResourcesWithRetry(ctx, pool.ResourcePoolID, models.ResourceFilter{})
 		if err != nil {
-			logging.Warn("failed to get resources from pool",
+			log.Println("failed to get resources from pool",
 				"pool_id", pool.ResourcePoolID,
 				"error", err)
 			continue

tests/fixtures/placement_fixtures.go

@@ -232,7 +232,7 @@ type CapacitySummary struct {
 func ValidEMBBPlacementRequest() PlacementRequest {
 	return PlacementRequest{
 		ID:      "placement-embb-001",
-		VNFSpec: eMBBVNFDeployment(),
+		VNFSpec: EMBBVNFDeployment(),
 		QoSProfile: QoSProfile{
 			Latency: LatencyRequirement{
 				Value: "20",

tn/agent/pkg/iperf_test.go

@@ -65,7 +65,7 @@ func setupTestIperfManager() *IperfManager {
 	manager := &IperfManager{
 		logger:  logger,
 		servers: make(map[string]*IperfServer),
-		mutex:   &sync.RWMutex{}, // Add mutex for thread safety
+		mu:      sync.RWMutex{}, // Add mutex for thread safety
 	}
 
 	return manager