Skip to content

Project Finished!#703

Open
GrimHaagenti wants to merge 2 commits into
the-csharp-academy:mainfrom
GrimHaagenti:main
Open

Project Finished!#703
GrimHaagenti wants to merge 2 commits into
the-csharp-academy:mainfrom
GrimHaagenti:main

Conversation

@GrimHaagenti

Copy link
Copy Markdown

:P

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GrimHaagenti thanks for the submission! The project needs a bit of work before approval. 😔

  1. DivisionHandler() can generate secondOperand = 0 inside the loop, which means this line can crash with a divide-by-zero exception: while (firstOperand % secondOperand != 0)

  2. matchLength is set to 5, but the game ends immediately after the first wrong answer. So a player may only answer 1 or 2 questions instead of completing the full round and the requirements say we need at least 5 rounds.

  3. You have a previousGamesHistory list and a ShowRecord() method, which is a good start. But RecordPoints() is only called when the player gets an answer wrong. If the player completes all 5 questions correctly, the score is not recorded, and currentPoints is not reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants