GND_8: No GND behaviour on relation fields, even if cfg'd as vocab

Bug logged at TLC-900

Author: kshepherd

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.html

@@ -71,8 +71,8 @@
             (selectItem)="onSelectItem($event)"
             (keydown.enter)="handleKeyDown($event)"
             >
-      <button *ngIf="(isExternalDataModal() | async) && !(hideRemoveButton)" class="btn btn-primary"  [disabled]="disableRemove" (click)="clearGndValue()" title="{{'gnd-lookup.gnd.button.remove' | translate}}"><i class="fas fa-trash"></i></button>
-      <button *ngIf="(isExternalDataModal() | async)" class="btn btn-primary" (click)="openModal()" title="{{'gnd-lookup.gnd.button.search' | translate}}"><i class="fas fa-search"></i></button>
+      <button *ngIf="((isExternalDataModal() | async)) && !(hideRemoveButton)" class="btn btn-primary"  [disabled]="disableRemove" (click)="clearGndValue()" title="{{'gnd-lookup.gnd.button.remove' | translate}}"><i class="fas fa-trash"></i></button>
+      <button *ngIf="((isExternalDataModal() | async))" class="btn btn-primary" (click)="openModal()" title="{{'gnd-lookup.gnd.button.search' | translate}}"><i class="fas fa-search"></i></button>
         </div>
   <div class="invalid-feedback" *ngIf="searchFailed && !(isExternalDataModal() | async)">Sorry, suggestions could not be loaded.</div>
 </div>

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts

@@ -196,7 +196,9 @@ export class DsDynamicOneboxComponent extends DsDynamicVocabularyComponent imple
     );
 
     this.isExternalDataModal$ = this.vocabulary$.pipe(
-      map((result: Vocabulary) => result.externalDataModal)
+      map((result: Vocabulary) => {
+        return (!this.isRelationship && result.externalDataModal)
+      })
     );
 
     this.subs.push(this.group.get(this.model.id).valueChanges.pipe(
@@ -476,4 +478,7 @@ export class DsDynamicOneboxComponent extends DsDynamicVocabularyComponent imple
     this.formBuilderService.addOrUpdateRemoveButtonStatus(key, value);
   }
 
+  get isRelationship() {
+    return hasValue(this.model.relationship);
+  }
 }