Shows an error message in case the input search is empty#9
Shows an error message in case the input search is empty#9lcnogueira wants to merge 1 commit intothe-road-to-graphql:masterfrom
Conversation
|
Good fix. I think the same applies if the pattern |
|
Got it, @rwieruch. Indeed, an error is thrown if the pattern is not matched. Actually, I just wanted to contribute somehow, because I'm not used to sending PR to open source projects 😃. Anyway, thanks for the answer 👍. |
|
Hey @lcnogueira Thanks for contributing in the first place! It really makes sense to dip one's toes into open source :) I would love to merge the PR, but then I have to adjust the tutorial too. I keep it open for now, because when I revisit my tutorial for this application in 2019, I take your change into account 💯 Wish you all the best! |
|
Great, @rwieruch. Deal 👍. |
An error occurs when the user tries to search for an empty string. So, I've done a small change that shows an error message in this case.
Please, let me know if there is something I can change to make this PR better, @rwieruch.