test(codecov): verify Codecov coverage + Test Analytics on a multi-file refactor#15
Closed
the0807 wants to merge 1 commit into
Closed
test(codecov): verify Codecov coverage + Test Analytics on a multi-file refactor#15the0807 wants to merge 1 commit into
the0807 wants to merge 1 commit into
Conversation
…nstants Three files, all hot-path code where re-tuning a literal previously required grep-and-replace. src/git/git-service.ts (7 constants): DEFAULT_EXEC_TIMEOUT_MS, FORCE_KILL_DELAY_MS, ACTIVITY_LOG_MAX_ENTRIES, MERGE_TREE_TIMEOUT_MS, REMOTE_NAMES_CACHE_TTL_MS, MAX_IMAGE_SIZE_BYTES, IMAGE_LOAD_TIMEOUT_MS src/git/git-graph-builder.ts (4 constants): UNIT_W / HALF_W / UNIT_H / HALF_H moved from function-local to module scope so the layout grid is documented in one place. src/services/repo-discovery.ts (2 constants): DEFAULT_EXEC_TIMEOUT_MS, FORCE_KILL_DELAY_MS — same pattern as GitService.exec for consistency. No behavior change. All 336 tests pass.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
Codecov integration verified end-to-end. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is testing
After enabling Codecov Test Analytics on main (commit b49d51f), this PR exercises the full PR-time signal pipeline:
What changes (for realism)
Three files touched so Codecov has a non-trivial file tree to display:
src/git/git-service.ts— 7 magic-number constants extractedsrc/git/git-graph-builder.ts— 4 layout constants moved from function-local to module scopesrc/services/repo-discovery.ts— 2 timeout constants extractedAll touched lines are already covered by existing tests, so patch coverage should report 100%.
What to verify