fixed switch to the lastest tab when reverse switching#5
Open
lokeb wants to merge 1 commit into
Open
Conversation
theborg3of5
requested changes
Jul 8, 2024
theborg3of5
left a comment
theborg3of5
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! See my suggestions inside. :)
| PinnedURL: "KeepOnePinnedTab_PinnedURL", | ||
| NoFocusPinnedTab: "KeepOnePinnedTab_NoFocusPinnedTab", | ||
|
|
Owner
There was a problem hiding this comment.
I don't mind including these whitespace changes, but they make it difficult to review your changes - please split them into a separate commit that does nothing else.
| LegacyKey: "KeepOnePinnedTab_NewTabPage", | ||
| }; | ||
|
|
||
| let lastTabId = -1 |
Owner
There was a problem hiding this comment.
I generally try to avoid global variables like this - is there some other way that we could detect that we're switching from the second tab to the first?
| keepNeededTabs(tab.windowId); | ||
| }); | ||
|
|
||
| chrome.tabs.onUpdated.addListener((tab) => |
Owner
There was a problem hiding this comment.
This looks like a leftover from debugging - it should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ctrl+shift+tab to did not allow switching to the lastest tab in reverse order.