HOTP: Remove redunant implode call

reedy · web-flow · commit 049f3d42d2f2 · 2026-03-22T12:42:09.000Z
diff --git a/src/HOTP.php b/src/HOTP.php
@@ -31,8 +31,6 @@ public static function generateByCounter(string $key, int $counter): HOTPResult
             $counter = $counter >> 8;
         }
 
-        $binCounter = implode($curCounter);
-
         // Pad to 8 chars
         $binCounter = str_pad(implode("", $curCounter), 8, chr(0), STR_PAD_LEFT);
 

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ public static function generateByCounter(string $key, int $counter): HOTPResult`
`31`	`31`	`$counter = $counter >> 8;`
`32`	`32`	`}`
`33`	`33`
`34`		`- $binCounter = implode($curCounter);`
`35`		`-`
`36`	`34`	`// Pad to 8 chars`
`37`	`35`	`$binCounter = str_pad(implode("", $curCounter), 8, chr(0), STR_PAD_LEFT);`
`38`	`36`