Remove MyCLabs\Enum support (#727) (#794)

PHP 8.1 native enums are the standard going forward. Security support for
PHP 8.0 has long passed and ends for 8.1 at the end of this year, so there
is no reason to continue supporting the myclabs/php-enum library.

- Delete MyCLabsEnumTypeMapper, MyCLabsEnumType and the @EnumType annotation
- Drop the MyCLabsEnumTypeMapper wiring from SchemaFactory and test harnesses
- Remove the getEnumTypeAnnotation() helper from AnnotationReader
- Drop myclabs/php-enum from require-dev
- Convert TestEnum and ProductTypeEnum fixtures to native backed enums
- Prune MyCLabs docs from current website/docs/ (versioned docs kept intact)

Author: oojacoboo

composer.json

@@ -31,7 +31,6 @@
         "doctrine/coding-standard": "^13.0",
         "ecodev/graphql-upload": "^7.0",
         "laminas/laminas-diactoros": "^3.5",
-        "myclabs/php-enum": "^1.6.6",
         "php-coveralls/php-coveralls": "^2.7",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.0",

src/AnnotationReader.php

@@ -10,7 +10,6 @@
 use ReflectionProperty;
 use TheCodingMachine\GraphQLite\Annotations\AbstractRequest;
 use TheCodingMachine\GraphQLite\Annotations\Decorate;
-use TheCodingMachine\GraphQLite\Annotations\EnumType;
 use TheCodingMachine\GraphQLite\Annotations\Exceptions\ClassNotFoundException;
 use TheCodingMachine\GraphQLite\Annotations\Exceptions\InvalidParameterException;
 use TheCodingMachine\GraphQLite\Annotations\ExtendType;
@@ -196,11 +195,6 @@ public function getExtendTypeAnnotation(ReflectionClass $refClass): ExtendType|n
         return $extendType;
     }
 
-    public function getEnumTypeAnnotation(ReflectionClass $refClass): EnumType|null
-    {
-        return $this->getClassAnnotation($refClass, EnumType::class);
-    }
-
     /** @param class-string<AbstractRequest> $annotationClass */
     public function getRequestAnnotation(ReflectionMethod $refMethod, string $annotationClass): AbstractRequest|null
     {

src/Annotations/EnumType.php

@@ -8,7 +8,6 @@
 use GraphQL\Type\Definition\NamedType;
 use GraphQL\Type\Definition\OutputType;
 use GraphQL\Type\Definition\Type as GraphQLType;
-use MyCLabs\Enum\Enum;
 use phpDocumentor\Reflection\DocBlock;
 use phpDocumentor\Reflection\Type;
 use phpDocumentor\Reflection\Types\Object_;
@@ -104,16 +103,12 @@ private function mapByClassName(string $enumClass): EnumType|null
         if (! enum_exists($enumClass)) {
             return null;
         }
-        /** @var class-string<Enum> $enumClass */
+        /** @var class-string<UnitEnum> $enumClass */
         $enumClass = ltrim($enumClass, '\\');
         if (isset($this->cacheByClass[$enumClass])) {
             return $this->cacheByClass[$enumClass];
         }
 
-        // phpcs:disable SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.MissingVariable
-        /** @var class-string<UnitEnum> $enumClass */
-        // phpcs:enable SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.MissingVariable
-
         $reflectionEnum = new ReflectionEnum($enumClass);
 
         $typeAnnotation = $this->annotationReader->getTypeAnnotation($reflectionEnum);

src/Mappers/Root/EnumTypeMapper.php

@@ -9,7 +9,6 @@
 use Kcs\ClassFinder\FileFinder\DefaultFileFinder;
 use Kcs\ClassFinder\Finder\ComposerFinder;
 use Kcs\ClassFinder\Finder\FinderInterface;
-use MyCLabs\Enum\Enum;
 use PackageVersions\Versions;
 use Psr\Container\ContainerInterface;
 use Psr\SimpleCache\CacheInterface;
@@ -41,7 +40,6 @@
 use TheCodingMachine\GraphQLite\Mappers\Root\FinalRootTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\IteratorTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\LastDelegatingTypeMapper;
-use TheCodingMachine\GraphQLite\Mappers\Root\MyCLabsEnumTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\NullableTypeMapperAdapter;
 use TheCodingMachine\GraphQLite\Mappers\Root\RootTypeMapperFactoryContext;
 use TheCodingMachine\GraphQLite\Mappers\Root\RootTypeMapperFactoryInterface;
@@ -70,7 +68,6 @@
 use TheCodingMachine\GraphQLite\Utils\NamespacedCache;
 
 use function array_reverse;
-use function class_exists;
 use function implode;
 use function md5;
 use function substr;
@@ -406,11 +403,6 @@ public function createSchema(): Schema
         $rootTypeMapper = new BaseTypeMapper($errorRootTypeMapper, $recursiveTypeMapper, $topRootTypeMapper);
         $rootTypeMapper = new EnumTypeMapper($rootTypeMapper, $annotationReader, $docBlockFactory, $classFinder, $classFinderComputedCache);
 
-        if (class_exists(Enum::class)) {
-            // Annotation support - deprecated
-            $rootTypeMapper = new MyCLabsEnumTypeMapper($rootTypeMapper, $annotationReader, $classFinder, $classFinderComputedCache);
-        }
-
         if (! empty($this->rootTypeMapperFactories)) {
             $rootSchemaFactoryContext = new RootTypeMapperFactoryContext(
                 $annotationReader,

src/Mappers/Root/MyCLabsEnumTypeMapper.php

@@ -47,7 +47,6 @@
 use TheCodingMachine\GraphQLite\Mappers\Root\FinalRootTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\IteratorTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\LastDelegatingTypeMapper;
-use TheCodingMachine\GraphQLite\Mappers\Root\MyCLabsEnumTypeMapper;
 use TheCodingMachine\GraphQLite\Mappers\Root\NullableTypeMapperAdapter;
 use TheCodingMachine\GraphQLite\Mappers\Root\RootTypeMapperInterface;
 use TheCodingMachine\GraphQLite\Mappers\Root\VoidTypeMapper;
@@ -369,14 +368,6 @@ protected function buildRootTypeMapper(): RootTypeMapperInterface
             $topRootTypeMapper,
         );
 
-        // Annotation support - deprecated
-        $rootTypeMapper = new MyCLabsEnumTypeMapper(
-            $rootTypeMapper,
-            $this->getAnnotationReader(),
-            new StaticClassFinder([]),
-            new HardClassFinderComputedCache(new Psr16Cache($arrayAdapter)),
-        );
-
         $rootTypeMapper = new EnumTypeMapper(
             $rootTypeMapper,
             $this->getAnnotationReader(),

src/SchemaFactory.php

@@ -124,7 +124,7 @@ public function testQueryProvider(): void
             'dateTimeImmutable' => '2017-01-01 01:01:01',
             'dateTime' => '2017-01-01 01:01:01',
             'id' => 42,
-            'enum' => TestEnum::ON(),
+            'enum' => TestEnum::ON,
         ];
 
         $resolve = $usersQuery->resolveFn;