fix: drop @internal annotation from InputField#795
Merged
oojacoboo merged 1 commit intothecodingmachine:masterfrom Apr 19, 2026
Merged
Conversation
The InputFieldMiddlewareInterface::process() method returns InputField|null, meaning userland middleware implementations must reference this class directly. Marking it @internal contradicts that public-API contract. Closes thecodingmachine#761
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
============================================
- Coverage 95.72% 94.73% -0.99%
- Complexity 1773 1832 +59
============================================
Files 154 172 +18
Lines 4586 4808 +222
============================================
+ Hits 4390 4555 +165
- Misses 196 253 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #761.
Problem
InputFieldis marked@internal, but userland cannot avoid referencing it: the publicInputFieldMiddlewareInterface::process()method signature returnsInputField|null, so any middleware implementation must import and returnInputFielddirectly.The
@internalmarker contradicts that public-API contract and causes static analysis tooling to flag legitimate middleware implementations.Fix
Drop the
@internalline from theInputFieldclass docblock. The class is alreadyfinal, which keeps its inheritance contract locked down; removing@internaljust acknowledges that the type is part of the public surface reachable through the middleware interface.Note: the sibling
QueryFieldclass retains@internalbecauseFieldMiddlewareInterface::process()returns the parentFieldDefinition, notQueryField— userland middleware never needs to nameQueryFielddirectly.