Skip to content

Commit 3af34b9

Browse files
slojosic-amdCISC
andauthored
ci : update the ROCm/HIP toolchain versions [no ci] (ggml-org#19891)
* [HIP] Update ROCm build container to rocm/dev-ubuntu-22.04:7.2 and HIP_SDK to 26.Q1 * revert container version --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
1 parent f20469d commit 3af34b9

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

.github/actions/windows-setup-rocm/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ runs:
1111
- name: Setup ROCm
1212
uses: ./.github/actions/install-exe
1313
with:
14-
url: https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-${{ inputs.version }}-WinSvr2022-For-HIP.exe
14+
url: https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-${{ inputs.version }}-Win11-For-HIP.exe
1515
args: -install

.github/workflows/build-cache.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868

6969
env:
7070
# Make sure this is in sync with build.yml
71-
HIPSDK_INSTALLER_VERSION: "25.Q3"
71+
HIPSDK_INSTALLER_VERSION: "26.Q1"
7272

7373
steps:
7474
- name: Clone

.github/workflows/build.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,10 +1175,8 @@ jobs:
11751175
runs-on: windows-2022
11761176

11771177
env:
1178-
# The ROCm version must correspond to the version used in the HIP SDK.
1179-
ROCM_VERSION: "6.4.2"
11801178
# Make sure this is in sync with build-cache.yml
1181-
HIPSDK_INSTALLER_VERSION: "25.Q3"
1179+
HIPSDK_INSTALLER_VERSION: "26.Q1"
11821180

11831181
steps:
11841182
- name: Clone
@@ -1188,7 +1186,7 @@ jobs:
11881186
- name: Grab rocWMMA package
11891187
id: grab_rocwmma
11901188
run: |
1191-
curl -o rocwmma.deb "https://repo.radeon.com/rocm/apt/${{ env.ROCM_VERSION }}/pool/main/r/rocwmma-dev/rocwmma-dev_1.7.0.60402-120~24.04_amd64.deb"
1189+
curl -o rocwmma.deb "https://repo.radeon.com/rocm/apt/7.2/pool/main/r/rocwmma-dev/rocwmma-dev_2.2.0.70200-43~24.04_amd64.deb"
11921190
7z x rocwmma.deb
11931191
7z x data.tar
11941192
@@ -1231,7 +1229,7 @@ jobs:
12311229
cmake -G "Unix Makefiles" -B build -S . `
12321230
-DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" `
12331231
-DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" `
1234-
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/opt/rocm-${{ env.ROCM_VERSION }}/include/" `
1232+
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/opt/rocm-7.2.0/include/" `
12351233
-DCMAKE_BUILD_TYPE=Release `
12361234
-DLLAMA_BUILD_BORINGSSL=ON `
12371235
-DROCM_DIR="${env:HIP_PATH}" `

0 commit comments

Comments
 (0)