Fixes #39494 - Fix create report button is enabled when state is 'running'

Author: Lukshio

webpack/JobInvocationDetail/JobInvocationConstants.js

@@ -38,6 +38,7 @@ export const STATUS = {
   SUCCEEDED: 'succeeded',
   FAILED: 'failed',
   CANCELLED: 'cancelled',
+  RUNNING: 'running',
 };
 
 export const STATUS_UPPERCASE = {

webpack/JobInvocationDetail/JobInvocationToolbarButtons.js

@@ -58,6 +58,12 @@ const JobInvocationToolbarButtons = ({ jobId, data }) => {
     );
   }, [jobId, reportTemplateJobId, templateInputId]);
 
+  const isCreateReportDisabled =
+    !canGenerateReportTemplates ||
+    task?.state === STATUS.RUNNING ||
+    task?.state === STATUS.PENDING ||
+    reportHref === undefined;
+
   const onActionFocus = useCallback(() => {
     const element = document.getElementById(
       `toggle-split-button-action-primary-${jobId}`
@@ -280,11 +286,7 @@ const JobInvocationToolbarButtons = ({ jobId, data }) => {
             className="button-create-report"
             href={reportHref}
             variant="secondary"
-            isDisabled={
-              !canGenerateReportTemplates ||
-              task?.state === STATUS.PENDING ||
-              reportHref === undefined
-            }
+            isDisabled={isCreateReportDisabled}
           >
             {__(`Create report`)}
           </Button>

webpack/JobInvocationDetail/__tests__/MainInformation.test.js

@@ -234,6 +234,41 @@ describe('JobInvocationDetailPage', () => {
     expect(screen.getByText('Rerun all')).toBeInTheDocument();
   });
 
+  it('disables Create report when the job task state is running', async () => {
+    const jobId = jobInvocationData.id;
+    const store = mockStore({
+      ...initialState,
+      JOB_INVOCATION_KEY: {
+        response: {
+          ...jobInvocationData,
+          task: { ...jobInvocationData.task, state: 'running' },
+        },
+      },
+      CURRENT_PERMISSIONS: {
+        response: {
+          results: [{ name: 'generate_report_templates' }],
+        },
+        status: 'RESOLVED',
+      },
+    });
+
+    render(
+      <Provider store={store}>
+        <JobInvocationDetailPage
+          match={{ params: { id: `${jobId}` } }}
+          {...props}
+        />
+      </Provider>
+    );
+
+    const createReportButton = screen.getByRole('link', {
+      name: 'Create report',
+    });
+
+    expect(createReportButton).toHaveAttribute('aria-disabled', 'true');
+    expect(createReportButton).toHaveClass('pf-m-disabled');
+  });
+
   it('shows scheduled date', async () => {
     const store = mockStore(initialStateScheduled);
     render(