fix no-magic-numbers errors

Author: kmalyjur

webpack/JobInvocationDetail/JobInvocationActions.js

@@ -15,6 +15,8 @@ import {
   UPDATE_JOB,
 } from './JobInvocationConstants';
 
+const POLLING_INTERVAL_MS = 1000;
+
 export const getJobInvocation = url => dispatch => {
   const fetchData = withInterval(
     get({
@@ -32,7 +34,7 @@ export const getJobInvocation = url => dispatch => {
         response?.data?.error?.message ||
         'Error',
     }),
-    1000
+    POLLING_INTERVAL_MS
   );
 
   dispatch(fetchData);

webpack/JobInvocationDetail/JobInvocationSystemStatusChart.js

@@ -52,7 +52,8 @@ const JobInvocationSystemStatusChart = ({
     return '0';
   };
   const chartSize = 105;
-  const [legendWidth, setLegendWidth] = useState(270);
+  const defaultLegendWidth = 270;
+  const [legendWidth, setLegendWidth] = useState(defaultLegendWidth);
 
   // Calculates chart legend width based on its content
   useEffect(() => {

webpack/JobInvocationDetail/TemplateInvocation.js

@@ -20,6 +20,10 @@ import { OutputToggleGroup } from './TemplateInvocationComponents/OutputToggleGr
 import { PreviewTemplate } from './TemplateInvocationComponents/PreviewTemplate';
 import { OutputCodeBlock } from './TemplateInvocationComponents/OutputCodeBlock';
 
+const COPIED_EXIT_DELAY_MS = 1500;
+const DEFAULT_EXIT_DELAY_MS = 600;
+const AUTO_REFRESH_INTERVAL_MS = 5000;
+
 const CopyToClipboard = ({ fullOutput }) => {
   const clipboardCopyFunc = async (event, text) => {
     try {
@@ -41,7 +45,7 @@ const CopyToClipboard = ({ fullOutput }) => {
       textId="code-content"
       aria-label="Copy to clipboard"
       onClick={e => onClick(e, fullOutput)}
-      exitDelay={copied ? 1500 : 600}
+      exitDelay={copied ? COPIED_EXIT_DELAY_MS : DEFAULT_EXIT_DELAY_MS}
       maxWidth="110px"
       variant="plain"
       onTooltipHidden={() => setCopied(false)}
@@ -111,7 +115,7 @@ export const TemplateInvocation = ({
         } else if (intervalRef.current) {
           clearInterval(intervalRef.current);
         }
-      }, 5000);
+      }, AUTO_REFRESH_INTERVAL_MS);
     }
 
     return () => {

webpack/JobInvocationDetail/TemplateInvocationComponents/OutputCodeBlock.js

@@ -8,6 +8,8 @@ import PropTypes from 'prop-types';
 import { Button } from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
 
+const MS_PER_SECOND = 1000;
+
 export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
   let lineCounter = 0;
   // eslint-disable-next-line no-control-regex
@@ -122,7 +124,7 @@ export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
         <div key={index} className={`line ${line.output_type}`}>
           <span
             className="counter"
-            title={new Date(line.timestamp * 1000).toISOString()}
+            title={new Date(line.timestamp * MS_PER_SECOND).toISOString()}
           >
             {lineCounter.toString().padStart(4, '\u00A0')}:{' '}
           </span>

webpack/JobWizard/JobWizard.js

@@ -40,6 +40,8 @@ import { StartsBeforeErrorAlert, StartsAtErrorAlert } from './StartsErrorAlert';
 import { Footer } from './Footer';
 import './JobWizard.scss';
 
+const SCHEDULE_CHECK_INTERVAL_MS = 5000;
+
 export const JobWizard = ({ rerunData }) => {
   const routerSearch = useSelector(selectRouterSearch);
   const [feature, setFeature] = useState(routerSearch.feature);
@@ -237,7 +239,7 @@ export const JobWizard = ({ rerunData }) => {
       }
     };
     updateStartsError();
-    const interval = setInterval(updateStartsError, 5000);
+    const interval = setInterval(updateStartsError, SCHEDULE_CHECK_INTERVAL_MS);
 
     return () => {
       interval && clearInterval(interval);

webpack/JobWizard/steps/Schedule/RepeatHour.js

@@ -14,11 +14,14 @@ import {
 import { translate as __ } from 'foremanReact/common/I18n';
 import { helpLabel } from '../form/FormHelpers';
 
+const MINUTES_IN_HOUR = 60;
+const DEFAULT_MINUTE_OPTIONS = [0, 15, 30, 45];
+
 export const RepeatHour = ({ repeatData, setRepeatData }) => {
   const isValidMinute = newMinute =>
     Number.isInteger(parseInt(newMinute, 10)) &&
     newMinute >= 0 &&
-    newMinute < 60;
+    newMinute < MINUTES_IN_HOUR;
 
   const { minute } = repeatData;
   useEffect(() => {
@@ -27,7 +30,7 @@ export const RepeatHour = ({ repeatData, setRepeatData }) => {
     }
   }, [minute, setRepeatData]);
   const [minuteOpen, setMinuteOpen] = useState(false);
-  const [options, setOptions] = useState([0, 15, 30, 45]);
+  const [options, setOptions] = useState(DEFAULT_MINUTE_OPTIONS);
   const [isAlertOpen, setIsAlertOpen] = useState(false);
   return (
     <FormGroup

webpack/JobWizard/steps/Schedule/RepeatWeek.js

@@ -5,12 +5,15 @@ import { translate as __, documentLocale } from 'foremanReact/common/I18n';
 import { RepeatDaily } from './RepeatDaily';
 import { noop } from '../../../helpers';
 
+const SUNDAY_REFERENCE_YEAR = 2017;
+const DAYS_IN_WEEK = 7;
+
 export const getWeekDays = () => {
   const locale = documentLocale().replace(/-/g, '_');
-  const baseDate = new Date(Date.UTC(2017, 0, 1)); // just a Sunday
+  const baseDate = new Date(Date.UTC(SUNDAY_REFERENCE_YEAR, 0, 1));
   const weekDays = [];
   const formatOptions = { weekday: 'short', timeZone: 'UTC' };
-  for (let i = 0; i < 7; i++) {
+  for (let i = 0; i < DAYS_IN_WEEK; i++) {
     try {
       weekDays.push(baseDate.toLocaleDateString(locale, formatOptions));
     } catch {

webpack/JobWizard/steps/Schedule/ScheduleRecurring.js

@@ -18,6 +18,8 @@ import { PurposeField } from './PurposeField';
 import { DateTimePicker } from '../form/DateTimePicker';
 import { WizardTitle } from '../form/WizardTitle';
 
+const ONE_MINUTE_MS = 60000;
+
 export const ScheduleRecurring = ({
   scheduleValue,
   setScheduleValue,
@@ -114,8 +116,8 @@ export const ScheduleRecurring = ({
                   setScheduleValue(current => ({
                     ...current,
                     startsAt: new Date(
-                      new Date().getTime() + 60000
-                    ).toISOString(), // 1 minute in the future
+                      new Date().getTime() + ONE_MINUTE_MS
+                    ).toISOString(),
                     isFuture: true,
                   }))
                 }

webpack/JobWizard/steps/Schedule/ScheduleType.js

@@ -10,6 +10,8 @@ import {
 import { WizardTitle } from '../form/WizardTitle';
 import { QueryType } from './QueryType';
 
+const ONE_MINUTE_MS = 60000;
+
 export const ScheduleType = ({
   scheduleType,
   isTypeStatic,
@@ -49,7 +51,9 @@ export const ScheduleType = ({
           onChange={() => {
             setScheduleValue(current => ({
               ...current,
-              startsAt: new Date(new Date().getTime() + 60000).toISOString(), // 1 minute in the future
+              startsAt: new Date(
+                new Date().getTime() + ONE_MINUTE_MS
+              ).toISOString(),
               scheduleType: SCHEDULE_TYPES.FUTURE,
               repeatType: repeatTypes.noRepeat,
             }));

webpack/JobWizard/steps/form/DateTimePicker.js

@@ -8,12 +8,17 @@ import {
 import { debounce } from 'lodash';
 import { translate as __, documentLocale } from 'foremanReact/common/I18n';
 
+const PAD_SLICE = -2;
+const DEBOUNCE_MS = 1000;
+
 const formatDateTime = d =>
   `${d.getFullYear()}-${`0${d.getMonth() + 1}`.slice(
-    -2
-  )}-${`0${d.getDate()}`.slice(-2)} ${`0${d.getHours()}`.slice(
-    -2
-  )}:${`0${d.getMinutes()}`.slice(-2)}:${`0${d.getSeconds()}`.slice(-2)}`;
+    PAD_SLICE
+  )}-${`0${d.getDate()}`.slice(PAD_SLICE)} ${`0${d.getHours()}`.slice(
+    PAD_SLICE
+  )}:${`0${d.getMinutes()}`.slice(PAD_SLICE)}:${`0${d.getSeconds()}`.slice(
+    PAD_SLICE
+  )}`;
 
 export const DateTimePicker = ({
   dateTime,
@@ -103,7 +108,7 @@ export const DateTimePicker = ({
         aria-label={`${ariaLabel} datepicker`}
         value={formattedDate}
         placeholder="yyyy/mm/dd"
-        onChange={debounce(onDateChange, 1000, {
+        onChange={debounce(onDateChange, DEBOUNCE_MS, {
           leading: false,
           trailing: true,
         })}
@@ -123,7 +128,7 @@ export const DateTimePicker = ({
         time={dateTime ? dateObject.toString() : ''}
         inputProps={dateTime ? {} : { value: '' }}
         placeholder={includeSeconds ? 'hh:mm:ss' : 'hh:mm'}
-        onChange={debounce(onTimeChange, 1000, {
+        onChange={debounce(onTimeChange, DEBOUNCE_MS, {
           leading: false,
           trailing: true,
         })}