Stop job invocation polling when the job finishes

handleSuccess unconditionally rescheduled the next poll, so the
useEffect's stopJobInvocationPolling call raced against in-flight
requests — the cleared timeout was immediately replaced by the
completing fetch. Check the response data inside handleSuccess
instead, and simplify the effect to only handle unmount cleanup.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: adamruzicka

webpack/JobInvocationDetail/JobInvocationActions.js

@@ -6,10 +6,20 @@ import {
   CANCEL_RECURRING_LOGIC,
   CHANGE_ENABLED_RECURRING_LOGIC,
   JOB_INVOCATION_KEY,
+  STATUS,
 } from './JobInvocationConstants';
 
 let pollTimeoutId = null;
 
+const isJobFinished = ({ status_label: statusLabel, task }) => {
+  const finished =
+    statusLabel === STATUS.FAILED ||
+    statusLabel === STATUS.SUCCEEDED ||
+    statusLabel === STATUS.CANCELLED;
+  const autoRefresh = task?.state === STATUS.PENDING || false;
+  return finished && !autoRefresh;
+};
+
 const scheduleNextPoll = (dispatch, url) => {
   pollTimeoutId = setTimeout(() => fetchJobInvocation(dispatch, url), 1000);
 };
@@ -20,7 +30,13 @@ const fetchJobInvocation = (dispatch, url, params = {}) => {
       key: JOB_INVOCATION_KEY,
       params,
       url,
-      handleSuccess: () => scheduleNextPoll(dispatch, url),
+      handleSuccess: ({ data }) => {
+        if (!isJobFinished(data)) {
+          scheduleNextPoll(dispatch, url);
+        } else {
+          pollTimeoutId = null;
+        }
+      },
       handleError: () => {
         pollTimeoutId = null;
       },

webpack/JobInvocationDetail/index.js

@@ -74,13 +74,10 @@ const JobInvocationDetailPage = ({
 
   useEffect(() => {
     dispatch(getJobInvocation(`/api/job_invocations/${id}`));
-    if (finished && !autoRefresh) {
-      stopJobInvocationPolling();
-    }
     return () => {
       stopJobInvocationPolling();
     };
-  }, [dispatch, id, finished, autoRefresh]);
+  }, [dispatch, id]);
 
   const pageStatus =
     items.id === undefined