Fixes #39494 - Fix create report button is enabled when state is 'running'#1041
Merged
Conversation
Member
Contributor
Author
It should be ok, the issue is the same, so this will fix it, and the #1030 PR should be fine |
Member
|
Could you update your pr? the other one was merged |
Contributor
Author
|
@MariaAga I also replaced test with RTL store helpers in new commit |
Contributor
Author
|
Linter issues unrelated. Redmine dont like second commit |
Lukshio
added
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
MariaAga
approved these changes
Jul 14, 2026
MariaAga
left a comment
MariaAga
left a comment
Member
There was a problem hiding this comment.
code looks good, ran the JS tests locally and they pass, and tested with packit that the button is disabled and enabled when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug where UI did not check for state 'running' -> button enabled instead of disabled