Skip to content

Fixes #39494 - Fix create report button is enabled when state is 'running' #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariaAga merged 2 commits into from
Jul 14, 2026
+238 −155
Merged

Fixes #39494 - Fix create report button is enabled when state is 'running' #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17e5ae3
Fixes #39494 - Fix create report button is enabled when state is 'run…
Lukshio Jul 3, 2026
86a096b
Update tests to RTL store helpers
Lukshio Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions webpack/JobInvocationDetail/JobInvocationConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const STATUS = {
SUCCEEDED: 'succeeded',
FAILED: 'failed',
CANCELLED: 'cancelled',
RUNNING: 'running',
};

export const STATUS_UPPERCASE = {
Expand Down
12 changes: 7 additions & 5 deletions webpack/JobInvocationDetail/JobInvocationToolbarButtons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ const JobInvocationToolbarButtons = ({ jobId, data }) => {
);
}, [jobId, reportTemplateJobId, templateInputId]);

const isCreateReportDisabled =
!canGenerateReportTemplates ||
task?.state === STATUS.RUNNING ||
task?.state === STATUS.PENDING ||
reportHref === undefined;

const onActionFocus = useCallback(() => {
const element = document.getElementById(
`toggle-split-button-action-primary-${jobId}`
Expand Down Expand Up @@ -280,11 +286,7 @@ const JobInvocationToolbarButtons = ({ jobId, data }) => {
className="button-create-report"
href={reportHref}
variant="secondary"
isDisabled={
!canGenerateReportTemplates ||
task?.state === STATUS.PENDING ||
reportHref === undefined
}
isDisabled={isCreateReportDisabled}
>
{__(`Create report`)}
</Button>
Expand Down
Loading
Loading