Skip to content

Fixes #38980 - Add automatic release process#55

Merged
adamruzicka merged 2 commits into
theforeman:masterfrom
ofedoren:feat-38980-add-rel-flow
Jan 8, 2026
Merged

Fixes #38980 - Add automatic release process#55
adamruzicka merged 2 commits into
theforeman:masterfrom
ofedoren:feat-38980-add-rel-flow

Conversation

@ofedoren
Copy link
Copy Markdown
Member

@ofedoren ofedoren commented Jan 8, 2026

@adamruzicka, I've set up trusted publishers on rubygems, so this should be ready to go.

@ofedoren ofedoren force-pushed the feat-38980-add-rel-flow branch from 6075f13 to ba8d0d4 Compare January 8, 2026 12:55
@ofedoren ofedoren changed the title Add automatic release process Fixes #38980 - Add automatic release process Jan 8, 2026
Copy link
Copy Markdown
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing in release.md, otherwise lgtm

Comment thread RELEASE.md Outdated
1. Checkout the branch you want to make the release from
2. Determine what the next version should be
- We try to follow [semantic versioning (semver)](https://semver.org)
- Usually we increase the major version only if we bumped the dependency on Foreman
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really make sense in this context.

How about this?

Suggested change
- Usually we increase the major version only if we bumped the dependency on Foreman
- Usually we increase the major version only if we bumped the required ruby version

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also seem weird, thus I've tried to capture the reality (at least that I've noticed): b216448

Copy link
Copy Markdown
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit d79af7f into theforeman:master Jan 8, 2026
10 checks passed
@adamruzicka
Copy link
Copy Markdown
Contributor

Thank you @ofedoren !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants