Skip to content

📌 Pin Deno to 2.9.1 in CI workflows#1202

Merged
cowboyd merged 3 commits into
v4from
cl/pin-deno
Jul 2, 2026
Merged

📌 Pin Deno to 2.9.1 in CI workflows#1202
cowboyd merged 3 commits into
v4from
cl/pin-deno

Conversation

@cowboyd

@cowboyd cowboyd commented Jul 2, 2026

Copy link
Copy Markdown
Member

Motivation

The v2.x floating tag on denoland/setup-deno lets deno fmt and deno lint rules shift under us between CI runs, producing surprise reformatting churn on unrelated branches (see the recent "format website assets for Deno 2.9" commit). Pinning a specific patch makes formatting and linting output reproducible until we choose to bump.

Approach

Replace deno-version: v2.x with v2.9.1 (current 2.9.x) in verify.yaml, publish.yml, codspeed.yaml, and preview.yml. and www.yaml

@pkg-pr-new

pkg-pr-new Bot commented Jul 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/effection@1202

commit: 4d3656c

@cowboyd cowboyd requested review from jbolda and taras July 2, 2026 20:09
@codspeed-hq

codspeed-hq Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing cl/pin-deno (4d3656c) with v4 (4812872)

Open in CodSpeed

@cowboyd cowboyd merged commit 56af00f into v4 Jul 2, 2026
19 checks passed
@cowboyd cowboyd deleted the cl/pin-deno branch July 2, 2026 20:36
taras added a commit that referenced this pull request Jul 5, 2026
Bumps `@deno/doc` 0.188.0 -> 0.199.0 and `@deno/graph` 0.89.0 -> 0.100.1, and
aligns the www CI job to Deno v2.9.1 (matches #1202).

`@deno/doc` >= 0.195.0 replaced the flat v1 `DocNode[]` model with the v2
`Document`/`Symbol`/`Declaration` model. The docs-rendering pipeline is migrated
to consume it natively:

- `doc()` returns `Record<url, Document>`; `Document.symbols` group declarations
  by name. `DocPageSection` holds a raw `Declaration`; render helpers receive
  the owning symbol via `type SymbolInfo = Omit<Symbol, "declarations">`
  (`extract(declaration, symbol)`, `Type({ declaration, symbol })`,
  `exportHash(declaration, symbol, i)`).
- `.def` replaces the per-kind def fields; `ClassMethodDef.def`; every
  `TsType*Def` payload is `.value`; namespace members recurse over
  `NamespaceDef.elements` (member Symbols).
- `kind === "import"` checks dropped; `Uint8Array` cast in blog-image-route.ts.

Note: `@deno/doc` 0.200.0-0.202.0 ship broken wasm bindings that fail to
instantiate under Deno (`__wbindgen_placeholder__`), so 0.199.0 is the newest
usable v2 release.
taras added a commit that referenced this pull request Jul 5, 2026
* ⬆️ Upgrade @deno/doc to 0.199.0 and migrate docs pipeline to v2

Bumps `@deno/doc` 0.188.0 -> 0.199.0 and `@deno/graph` 0.89.0 -> 0.100.1, and
aligns the www CI job to Deno v2.9.1 (matches #1202).

`@deno/doc` >= 0.195.0 replaced the flat v1 `DocNode[]` model with the v2
`Document`/`Symbol`/`Declaration` model. The docs-rendering pipeline is migrated
to consume it natively:

- `doc()` returns `Record<url, Document>`; `Document.symbols` group declarations
  by name. `DocPageSection` holds a raw `Declaration`; render helpers receive
  the owning symbol via `type SymbolInfo = Omit<Symbol, "declarations">`
  (`extract(declaration, symbol)`, `Type({ declaration, symbol })`,
  `exportHash(declaration, symbol, i)`).
- `.def` replaces the per-kind def fields; `ClassMethodDef.def`; every
  `TsType*Def` payload is `.value`; namespace members recurse over
  `NamespaceDef.elements` (member Symbols).
- `kind === "import"` checks dropped; `Uint8Array` cast in blog-image-route.ts.

Note: `@deno/doc` 0.200.0-0.202.0 ship broken wasm bindings that fail to
instantiate under Deno (`__wbindgen_placeholder__`), so 0.199.0 is the newest
usable v2 release.

* 🐛 Fix off-by-one in API "View code" source links

`@deno/doc` v2 changed `Location.line` from 1-indexed to 0-indexed (deno_doc
#150/#777). GitHub's `#L<n>` anchor is 1-indexed, so the source links generated
in package.ts / package/node.ts pointed one line above the symbol's
declaration. Add `+ 1`.

---------

Co-authored-by: Taras Mankovski <74687+taras@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants