[Muse & Mist] Footer is not at the bottom of the page when the sidebar display is removed#1718
Open
egandx wants to merge 1 commit intotheme-next:masterfrom
Open
[Muse & Mist] Footer is not at the bottom of the page when the sidebar display is removed#1718egandx wants to merge 1 commit intotheme-next:masterfrom
egandx wants to merge 1 commit intotheme-next:masterfrom
Conversation
|
Thanks so much for opening your first PR here! |
|
“egandx” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue resolved: N/A
Configuration info:
Next version: 7.8.0 (Current latest version)
Scheme: Mist & Muse
When sidebar display is removed,footer is not at the bottom of the page.
What is the new behavior?
when CONFIG.sidebar.display === 'remove', not adjusting the position of the sidebar