Added prepare statement when building where clause#2365
Merged
Conversation
harunollyo
requested changes
Feb 17, 2026
harunollyo
requested changes
Feb 17, 2026
| if ( in_array( $upper_operator, array( 'IN', 'NOT IN' ), true ) ) { | ||
| $value = '(' . self::prepare_in_clause( $value ) . ')'; | ||
| } elseif ( in_array( $upper_operator, array( 'BETWEEN', 'NOT BETWEEN' ), true ) ) { | ||
| $values = explode( 'AND', $value ); |
harunollyo
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As a part of security fix in 3.9.4, where sql injection was possible through the
coupon_codeparameter a fix was added whereesc_sqlwas called to remove any kind of sql injection, however this was not the correct fix. The correct fix is using prepare statement inprepare_where_clausemethod where any user value can be passed. Therefore, I have updated the method specifically themake_clausemethod that is being used inprepare_where_clauseonly, which creates the final clause, here i have checked whether the value is string or integer and added appropriate prepare statement for each type. I have also added some new unit test cases to check theprepare_where_clauseoutput making sure it doesn't break the query.Test Case Results