Quiz Attempts list design issue fixes#2653
Merged
Anindra123 merged 12 commits into4.0.0-devfrom May 8, 2026
Merged
Conversation
sazedul-haque
requested changes
May 5, 2026
| <?php | ||
| $sorting_icon = 'DESC' === $this->order ? Icon::ASCENDING : Icon::DESCENDING; | ||
| SvgIcon::make()->name( $sorting_icon )->size( 16 )->color( Color::SECONDARY )->render(); | ||
| SvgIcon::make()->name( $sorting_icon )->size( $this->icon_size )->color( Color::SECONDARY )->render(); |
Collaborator
There was a problem hiding this comment.
This will be resolved from designers
sazedul-haque
requested changes
May 5, 2026
| private function get_kebab_button() { | ||
| $kebab_button = Button::make() | ||
| ->icon( Icon::THREE_DOTS_VERTICAL ) | ||
| ->icon( SvgIcon::make()->name( Icon::ELLIPSES )->size( 20 )->get() ) |
Collaborator
There was a problem hiding this comment.
Only this ->icon( Icon:: ELLIPSES ) should fix the issue.
| */ | ||
| class Sorting extends BaseComponent { | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Please remove this changes
sazedul-haque
requested changes
May 7, 2026
| .tutor-preview-trigger { | ||
| display: inline; | ||
| position: relative; | ||
| @include tutor-text-truncate; |
Collaborator
There was a problem hiding this comment.
This will break design. We need to find other solution. For now remove this.
sazedul-haque
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.