refactor(tutor-setup): enforce minimum loading duration for tutor setup & clean up loading animation and optimize code#2903
Open
nur-alam wants to merge 3 commits into
Open
refactor(tutor-setup): enforce minimum loading duration for tutor setup & clean up loading animation and optimize code#2903nur-alam wants to merge 3 commits into
nur-alam wants to merge 3 commits into
Conversation
Remove unused `isLoadingTextLooping` state variable and related checks in the loading animation logic. Cache the sample course import flag to avoid repeated form data lookups. Add a 2-second delay before fading out the loading screen.
replace fixed 2000ms wait with dynamic calculation based on onboarding start time to ensure at least 6000ms total loading screen display
nur-alam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enforce minimum loading duration for tutor setup
wait with dynamic calculation based on onboarding start time to ensure at least 6000ms total loading screen display
Remove unused
isLoadingTextLoopingstate variable and related checks in the loading animation logic. Cache the sample course import flag to avoid repeated form data lookups.