Fix nightly Linux packaging and update GitHub actions

Author: themuffinator

.github/workflows/nightly.yml

@@ -31,12 +31,12 @@ jobs:
       head_sha: ${{ steps.version.outputs.head_sha }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.x"
 
@@ -77,13 +77,13 @@ jobs:
         os: [windows-latest, macos-latest, ubuntu-latest]
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
           ref: ${{ needs.prepare.outputs.head_sha }}
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.x"
 
@@ -121,7 +121,7 @@ jobs:
         run: meson compile -C builddir
 
       - name: Upload Build Artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: pakfu-build-${{ matrix.os }}
           path: |
@@ -140,12 +140,12 @@ jobs:
         os: [windows-latest, macos-latest, ubuntu-latest]
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           ref: ${{ needs.prepare.outputs.head_sha }}
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.x"
 
@@ -157,7 +157,7 @@ jobs:
           modules: qtmultimedia qtimageformats
 
       - name: Download Build Artifact
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: pakfu-build-${{ matrix.os }}
           path: .
@@ -224,12 +224,12 @@ jobs:
         os: [windows-latest, macos-latest, ubuntu-latest]
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           ref: ${{ needs.prepare.outputs.head_sha }}
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.x"
 
@@ -241,7 +241,7 @@ jobs:
           modules: qtmultimedia qtimageformats
 
       - name: Download Build Artifact
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: pakfu-build-${{ matrix.os }}
           path: .
@@ -343,7 +343,7 @@ jobs:
             --arch "${PAKFU_ARCH}"
 
       - name: Upload Package Artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: pakfu-dist-${{ matrix.os }}
           path: dist/*
@@ -356,18 +356,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
           ref: ${{ needs.prepare.outputs.head_sha }}
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.x"
 
       - name: Download Package Artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           path: dist
           merge-multiple: true

scripts/package_linux.sh

@@ -128,20 +128,31 @@ if [[ ! -e "${app_dir}/usr/lib/libQt6Core.so.6" ]]; then
   exit 1
 fi
 
-pakfu_ldd="$(ldd "${app_dir}/usr/bin/pakfu" 2>/dev/null || true)"
+app_dir_abs="$(cd "${app_dir}" && pwd)"
+app_lib_dir="${app_dir_abs}/usr/lib"
+
+# CI exposes the build-time Qt via LD_LIBRARY_PATH. Validate with the AppDir
+# library directory first, matching the runtime environment provided by AppRun.
+pakfu_ldd="$(LD_LIBRARY_PATH="${app_lib_dir}" ldd "${app_dir}/usr/bin/pakfu" 2>/dev/null || true)"
 if printf "%s\n" "${pakfu_ldd}" | grep -q "not found"; then
   echo "Packaged pakfu binary still has unresolved runtime dependencies:" >&2
   printf "%s\n" "${pakfu_ldd}" >&2
   exit 1
 fi
 
-app_dir_abs="$(cd "${app_dir}" && pwd)"
-if ! printf "%s\n" "${pakfu_ldd}" | grep -F "libQt6Core.so.6 => ${app_dir_abs}/" >/dev/null; then
+if ! printf "%s\n" "${pakfu_ldd}" | grep -F "libQt6Core.so.6 => ${app_lib_dir}/" >/dev/null; then
   echo "Packaged pakfu binary is not resolving Qt Core from the deployed AppDir." >&2
   printf "%s\n" "${pakfu_ldd}" >&2
   exit 1
 fi
 
+external_qt_libs="$(printf "%s\n" "${pakfu_ldd}" | grep -E "libQt6[^[:space:]]*\\.so" | grep -Fv "=> ${app_lib_dir}/" || true)"
+if [[ -n "${external_qt_libs}" ]]; then
+  echo "Packaged pakfu binary is resolving Qt libraries outside the deployed AppDir." >&2
+  printf "%s\n" "${external_qt_libs}" >&2
+  exit 1
+fi
+
 if [[ ! -x "${app_dir}/AppRun" ]]; then
   echo "linuxdeployqt did not create an executable AppRun launcher in ${app_dir}." >&2
   exit 1