feat: Add ReadEvents with the associated dependencies and the test client file was split#16
Merged
Merged
Conversation
…ient file was split
# Conflicts: # src/Client.php
goloroden
requested changes
Jul 19, 2025
Member
goloroden
left a comment
goloroden
left a comment
There was a problem hiding this comment.
@wundii Vielen Dank für diesen PR 😊
Der gefällt mir schon sehr, sehr gut – insbesondere das mit dem yield ist echt schön gelöst, und auch insgesamt gefällt mir gut, wie der Code geschrieben ist. Danke dafür 😊
Ich habe nur noch ein paar Mini-Anmerkungen, kannst Du Dir die bitte noch mal anschauen?
Das einzige, was dann noch fehlt, ist die Doku – aber da würde ich vorschlagen, dass wir die ganz am Ende in einem Rutsch machen. Da wäre es ohnehin sinnvoll, wenn ich die schreibe (nicht, weil ich so toll darin wäre, Doku zu schreiben, sondern weil ich auch alle anderen Dokus geschrieben habe, und es dann einen einheitlichen Stil hat), und Du dann zB nur noch mal drüberschaust.
goloroden
previously approved these changes
Jul 20, 2025
goloroden
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.