chore: define matrix build for different PHP versions#7
Merged
Conversation
goloroden
requested changes
May 25, 2025
Member
goloroden
left a comment
goloroden
left a comment
There was a problem hiding this comment.
Hi @Forestsoft-de 👋
Vielen Dank für den PR!
Ich habe ein paar Kommentare dagelassen, kannst Du Dir die bitte noch mal anschauen?
Forestsoft-de
force-pushed
the
ci_matrix_build
branch
from
bb3f9ab to
bc49792
Compare
goloroden
requested changes
May 26, 2025
Forestsoft-de
force-pushed
the
ci_matrix_build
branch
from
31e0501 to
4106ede
Compare
Forestsoft-de
force-pushed
the
ci_matrix_build
branch
from
c9df2d3 to
a771954
Compare
goloroden
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr introduce 2 major improvements to the qa: