Skip to content

Commit 9464da2

Browse files
authored
Merge pull request #11 from theodo-group/refactor/dap-transport-connector
Refactor DAP attach: transport + connector strategies (replaces #10)
2 parents c8f881b + b376da3 commit 9464da2

18 files changed

Lines changed: 1093 additions & 530 deletions

File tree

src/cdp/session.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type { RemoteObject } from "../formatter/values.ts";
55
import { formatValue } from "../formatter/values.ts";
66
import { createLogger, type Logger } from "../logger/index.ts";
77
import { BaseSession, type WaitForStopOptions } from "../session/base-session.ts";
8-
import type { BreakpointListItem, SessionCapabilities, SourceMapInfo } from "../session/session.ts";
8+
import type { BreakpointListItem, SessionFeatures, SourceMapInfo } from "../session/session.ts";
99
import type {
1010
AttachResult,
1111
ConsoleMessage,
@@ -102,7 +102,7 @@ export class CdpSession extends BaseSession {
102102
private log: Logger<"session">;
103103
private cdpLog: Logger<"cdp">;
104104

105-
readonly capabilities: SessionCapabilities = {
105+
readonly features: SessionFeatures = {
106106
functionBreakpoints: false,
107107
logpoints: true,
108108
hotpatch: true,

src/daemon/entry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ server.onRequest(async (req: DaemonRequest): Promise<DaemonResponse> => {
150150
case "break-fn": {
151151
const session = requireSession();
152152
if (isError(session)) return session;
153-
if (!session.capabilities.functionBreakpoints || !session.setFunctionBreakpoint) {
153+
if (!session.features.functionBreakpoints || !session.setFunctionBreakpoint) {
154154
return {
155155
ok: false,
156156
error: "Function breakpoints are only supported with DAP runtimes (e.g. --runtime lldb)",
@@ -365,7 +365,7 @@ server.onRequest(async (req: DaemonRequest): Promise<DaemonResponse> => {
365365
case "modules": {
366366
const session = requireSession();
367367
if (isError(session)) return session;
368-
if (!session.capabilities.modules || !session.getModules) {
368+
if (!session.features.modules || !session.getModules) {
369369
return {
370370
ok: false,
371371
error: "Modules are only available in DAP mode (e.g. --runtime lldb)",

0 commit comments

Comments
 (0)