Improved has{nt}_X implementation - #370
Open
RampantDespair wants to merge 3 commits into
Open
Conversation
theory
approved these changes
Jul 26, 2026
theory
left a comment
theory
left a comment
Owner
There was a problem hiding this comment.
Looks good. 50/72 commit message please.
RampantDespair
added a commit
to RampantDespair/pgtap
that referenced
this pull request
Jul 26, 2026
RampantDespair
added a commit
to RampantDespair/pgtap
that referenced
this pull request
Jul 26, 2026
Added missing `schema, table` variants of `hasnt_pk()`, `has_fk()`, `hasnt_fk()`, `has_unique()`, and `has_check()`, and added `hasnt_unique()` and `hasnt_check()`. Also changed `has_unique()` argument types from `TEXT` to `NAME` so they can share a consistent overload order with the other constraint assertions.
Author
Done
Done
Done, hopefully I didn't break anything by changing the existing history, but now the commit messages should be compliant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363 [2/3]
As discussed this is the first part of the PR split -> implementation symmetry, part 2.
All 4 now follow: