BC support of Custom Claims#1222
Closed
ElisDN wants to merge 2 commits into
Closed
Conversation
Member
|
Thanks @ElisDN - this is a simple solution but does require overriding of existing functions. I think ideally, long term, I'd like something more deliberately baked into the package. There are a few other potential PRs which go further than this one so for that reason, I won't be proceeding with this at present. Thank you for your efforts though and apologies I won't be merging this in at this time. |
|
@Sephster neither this nor the other |
|
@Sephster is there any PR finally considered to add custom claims support? It's so useful for SPA and actually discussing here for a couple of years. Thanks. |
Member
|
Definitely want to add this so not off the radar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy backward compatible way for parsing custom claims for #1120, #1122 and #1183 in the next 8.x release.
How to use it
For example, if you want to add a role field into JWT, just add
$roleproperty into your token entity and overrideconvertToJWTmethod from trait for addingroleclaim:After all fetch user role and fill the property in token repository:
And now you can retreive
$request->getAttribute('oauth_custom_claims')with value like['role' => 'admin'].