Skip to content

Commit 1b5662f

Browse files
therealalephclaude
andcommitted
ci(release): make i686-pc-windows-msvc continue-on-error
Companion to the Rust 1.77.2 pin: if the deps' MSRV ever moves above 1.77, the i686 target will fail to build, but we don't want it to block the rest of the release. Mirror the mipsel-softfloat approach. If/when this triggers, options are dropping i686 entirely or moving to the tier-3 i686-win7-windows-msvc target. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 05fca99 commit 1b5662f

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,12 @@ jobs:
112112
# mipsel-softfloat is best-effort: the Rust tier-3 target occasionally
113113
# regresses. Letting it fail keeps the main release going so
114114
# desktop/Android users aren't blocked by MT7621 router support.
115-
continue-on-error: ${{ matrix.mipsel_softfloat == true }}
115+
# i686-pc-windows-msvc is similarly best-effort — pinned to Rust
116+
# 1.77.2 for Win7 compat (#318), so a future dep MSRV bump above
117+
# 1.77 will fail this one target. Letting it skip keeps the rest
118+
# of the release unblocked; we'd then choose between dropping the
119+
# target or moving to the tier-3 win7-msvc target with build-std.
120+
continue-on-error: ${{ matrix.mipsel_softfloat == true || matrix.target == 'i686-pc-windows-msvc' }}
116121

117122
steps:
118123
# Heal any root-owned leftovers from a previous mipsel docker

0 commit comments

Comments
 (0)