Skip to content

Commit f6fcbff

Browse files
authored
Merge pull request #150 from freeinternet865/fix/android-only-split-empty
fix(android): keep empty ONLY split lists self-excluded
2 parents 7e993af + 9df9761 commit f6fcbff

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

android/app/src/main/java/com/therealaleph/mhrv/MhrvVpnService.kt

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,22 @@ class MhrvVpnService : VpnService() {
191191
builder.addDisallowedApplication(packageName)
192192
} catch (_: Throwable) {}
193193
} else {
194+
var allowed = 0
194195
for (pkg in cfg.splitApps) {
195196
if (pkg == packageName) continue // can't tunnel ourselves
196-
try { builder.addAllowedApplication(pkg) } catch (e: Throwable) {
197+
try {
198+
builder.addAllowedApplication(pkg)
199+
allowed++
200+
} catch (e: Throwable) {
197201
Log.w(TAG, "addAllowedApplication($pkg) failed: ${e.message}")
198202
}
199203
}
204+
if (allowed == 0) {
205+
Log.w(TAG, "ONLY mode had no usable apps — falling back to ALL")
206+
try {
207+
builder.addDisallowedApplication(packageName)
208+
} catch (_: Throwable) {}
209+
}
200210
}
201211
}
202212
SplitMode.EXCEPT -> {

0 commit comments

Comments
 (0)