Skip to content

Commit 6ddc0db

Browse files
committed
PHP 7.4 is now required. Require variables defined within file-scope now.
1 parent c4b4f00 commit 6ddc0db

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

TSF/ruleset.xml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,11 @@
99
</rule>
1010

1111
<config name="minimum_supported_wp_version" value="5.5"/>
12-
<config name="testVersion" value="7.3-"/>
12+
<config name="testVersion" value="7.4-"/>
1313

1414
<rule ref="WordPress-Docs"/>
1515
<rule ref="WordPress-Extra"/>
16-
17-
<rule ref="VariableAnalysis">
18-
<properties>
19-
<!-- This removes a nag whenever we forward variables to require... -->
20-
<!-- Probably TEMP, for it is a bad practise not seeing other code. -->
21-
<property name="allowUnusedVariablesBeforeRequire" type="bool" value="1"/>
22-
</properties>
23-
</rule>
16+
<rule ref="VariableAnalysis"/>
2417

2518
<rule ref="PHPCompatibilityWP"/>
2619
<rule ref="WordPress-Core">

composer.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,10 @@
6060
"check-complete-strict": [
6161
"@php ./vendor/phpcsstandards/phpcsdevtools/bin/phpcs-check-feature-completeness ./TSF"
6262
]
63+
},
64+
"config": {
65+
"allow-plugins": {
66+
"dealerdirect/phpcodesniffer-composer-installer": true
67+
}
6368
}
6469
}

0 commit comments

Comments
 (0)