sfc: fix error code in efx_devlink_info_running_versions()

error27 · Paolo Abeni · commit 051ffb001b8a · 2026-04-30T13:44:30.000+02:00
Return -EIO if efx_mcdi_rpc() doesn't return enough space. Fixes: 14743dd ("sfc: add devlink info support for ef100") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Edward Cree <ecree.xilinx@gmail.com> Link: https://patch.msgid.link/afGpsbLRHL4_H0KS@stanley.mountain Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
@@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
 	if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
 		netif_err(efx, drv, efx->net_dev,
 			  "mcdi MC_CMD_GET_VERSION failed\n");
-		return rc;
+		return rc ?: -EIO;
 	}
 
 	/* Handle previous output */

Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,`
`531`	`531`	`if (rc \|\| outlength < MC_CMD_GET_VERSION_OUT_LEN) {`
`532`	`532`	`netif_err(efx, drv, efx->net_dev,`
`533`	`533`	`"mcdi MC_CMD_GET_VERSION failed\n");`
`534`		`- return rc;`
	`534`	`+ return rc ?: -EIO;`
`535`	`535`	`}`
`536`	`536`
`537`	`537`	`/* Handle previous output */`