Skip to content

Commit 0899753

Browse files
mcgrofsnitm
authored andcommitted
dm: add add_disk() error handling
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. There are two calls to dm_setup_md_queue() which can fail then, one on dm_early_create() and we can easily see that the error path there calls dm_destroy in the error path. The other use case is on the ioctl table_load case. If that fails userspace needs to call the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other failure. Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent ea3dba3 commit 0899753

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/md/dm.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2086,7 +2086,9 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t)
20862086
if (r)
20872087
return r;
20882088

2089-
add_disk(md->disk);
2089+
r = add_disk(md->disk);
2090+
if (r)
2091+
return r;
20902092

20912093
r = dm_sysfs_init(md);
20922094
if (r) {

0 commit comments

Comments
 (0)