ASoC: SOF: debug: clarify operator precedence

plbossart · plbossart · commit 0ed6b31042e8 · 2021-12-09T09:43:05.000-06:00
cppcheck warning:

sound/soc/sof/debug.c:398:46: style: Clarify calculation precedence
for '&amp;' and '?'. [clarifyCalculation]
 char *level = flags &amp; SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
                                             ^

Signed-off-by: Pierre-Louis Bossart &lt;pierre-louis.bossart@linux.intel.com&gt;
diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
@@ -395,7 +395,7 @@ static void snd_sof_dbg_print_fw_state(struct snd_sof_dev *sdev, const char *lev
 
 void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, const char *msg, u32 flags)
 {
-	char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
+	char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;
 	bool print_all = sof_debug_check_flag(SOF_DBG_PRINT_ALL_DUMPS);
 
 	if (flags & SOF_DBG_DUMP_OPTIONAL && !print_all)

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ static void snd_sof_dbg_print_fw_state(struct snd_sof_dev sdev, const char lev`
`395`	`395`
`396`	`396`	`void snd_sof_dsp_dbg_dump(struct snd_sof_dev sdev, const char msg, u32 flags)`
`397`	`397`	`{`
`398`		`- char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;`
	`398`	`+ char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;`
`399`	`399`	`bool print_all = sof_debug_check_flag(SOF_DBG_PRINT_ALL_DUMPS);`
`400`	`400`
`401`	`401`	`if (flags & SOF_DBG_DUMP_OPTIONAL && !print_all)`