Skip to content

Commit 1a1414c

Browse files
Sasha Levingroeck
authored andcommitted
hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference
kconfiglint reports: X001: CONFIG_SENSORS_SBRMI referenced in Makefile but not defined in any Kconfig The SB-RMI hardware monitoring driver was originally introduced in commit 5a0f50d ("hwmon: Add support for SB-RMI power module") with both a Kconfig entry (CONFIG_SENSORS_SBRMI) and a Makefile line (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) in drivers/hwmon/. Commit e156586 ("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc") moved the driver to drivers/misc/amd-sbi/ to support additional functionality beyond hardware monitoring. That commit correctly removed the Kconfig entry from drivers/hwmon/Kconfig, moved the source file drivers/hwmon/sbrmi.c to drivers/misc/amd-sbi/sbrmi.c, and created new Kconfig/Makefile entries in drivers/misc/amd-sbi/ with a renamed symbol (CONFIG_AMD_SBRMI_I2C). However, the Makefile line in drivers/hwmon/Makefile was not removed in that commit. The orphaned line references a CONFIG symbol that no longer exists and a source file that is no longer present, so it has no effect on the build — but it is dead code that should be cleaned up. Remove the stale Makefile reference. Assisted-by: Claude:claude-opus-4-6 kconfiglint Signed-off-by: Sasha Levin <sashal@kernel.org> Link: https://lore.kernel.org/r/20260426000319.55908-1-sashal@kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 5ed26ff commit 1a1414c

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/hwmon/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ obj-$(CONFIG_SENSORS_PWM_FAN) += pwm-fan.o
201201
obj-$(CONFIG_SENSORS_QNAP_MCU_HWMON) += qnap-mcu-hwmon.o
202202
obj-$(CONFIG_SENSORS_RASPBERRYPI_HWMON) += raspberrypi-hwmon.o
203203
obj-$(CONFIG_SENSORS_SBTSI) += sbtsi_temp.o
204-
obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o
205204
obj-$(CONFIG_SENSORS_SCH56XX_COMMON)+= sch56xx-common.o
206205
obj-$(CONFIG_SENSORS_SCH5627) += sch5627.o
207206
obj-$(CONFIG_SENSORS_SCH5636) += sch5636.o

0 commit comments

Comments
 (0)