Skip to content

Commit 1cc4cda

Browse files
committed
nvme-pci: fix missed admin queue sq doorbell write
We can batch admin commands submitted through io_uring_cmd passthrough, which means bd->last may be false and skips the doorbell write to aggregate multiple commands per write. If a subsequent command can't be dispatched for whatever reason, we have to provide the blk-mq ops' commit_rqs callback in order to ensure we properly update the doorbell. Fixes: 58e5bde ("nvme: enable uring-passthrough for admin commands") Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Kanchan Joshi <joshi.k@samsung.com> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent 5d10069 commit 1cc4cda

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/nvme/host/pci.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2239,6 +2239,7 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled)
22392239
static const struct blk_mq_ops nvme_mq_admin_ops = {
22402240
.queue_rq = nvme_queue_rq,
22412241
.complete = nvme_pci_complete_rq,
2242+
.commit_rqs = nvme_commit_rqs,
22422243
.init_hctx = nvme_admin_init_hctx,
22432244
.init_request = nvme_pci_init_request,
22442245
.timeout = nvme_timeout,

0 commit comments

Comments
 (0)