Skip to content

Commit 266cddf

Browse files
cyndisthierryreding
authored andcommitted
gpu: host1x: Fix use-after-free in host1x_bo_clear_cached_mappings
__host1x_bo_unpin() drops the last reference to the mapping and frees it, so we can't dereference mapping afterwards. The cache itself outlives the mapping, so use the cache local variable instead. Reported-by: Dan Carpenter <error27@gmail.com> Closes: https://lore.kernel.org/linux-tegra/ah6ErK6f4kVudVIA@stanley.mountain/T/#u Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://patch.msgid.link/20260603-host1x-bocache-leak-fix-v1-1-494101dbfd30@nvidia.com
1 parent ddb44ba commit 266cddf

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/host1x/bus.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,10 +1012,10 @@ void host1x_bo_clear_cached_mappings(struct host1x_bo *bo)
10121012
if (WARN_ON(!cache))
10131013
continue;
10141014

1015-
mutex_lock(&mapping->cache->lock);
1015+
mutex_lock(&cache->lock);
10161016
WARN_ON(kref_read(&mapping->ref) != 1);
10171017
__host1x_bo_unpin(&mapping->ref);
1018-
mutex_unlock(&mapping->cache->lock);
1018+
mutex_unlock(&cache->lock);
10191019
}
10201020
}
10211021
EXPORT_SYMBOL(host1x_bo_clear_cached_mappings);

0 commit comments

Comments
 (0)