Skip to content

Commit 34808ac

Browse files
nissampabroonie
authored andcommitted
regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
i2c_smbus_write_word_data() expects a plain u16, but cpu_to_le16() returns __le16 (a sparse-restricted endian type), causing: drivers/base/regmap/regmap-i2c.c:340: sparse: incorrect type in argument 3 (different base types) expected unsigned short [usertype] value got restricted __le16 [usertype] SMBus already defines byte ordering internally, so cpu_to_le16() is wrong here. Replace it with a plain (u16) cast. Fixes: bad4bd2 ("regmap-i2c: add SMBus byte/word reg16 bus for adapters lacking I2C_FUNC_I2C") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202605161621.mY5zFh4D-lkp@intel.com/ Signed-off-by: Nishanth Sampath Kumar <nissampa@cisco.com> Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 254f496 commit 34808ac

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/base/regmap/regmap-i2c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ static int regmap_smbus_word_write_reg16(void *context, const void *data,
337337
val = ((u8 *)data)[2];
338338

339339
return i2c_smbus_write_word_data(i2c, addr_hi,
340-
cpu_to_le16(((u16)val << 8) | addr_lo));
340+
((u16)val << 8) | addr_lo);
341341
}
342342

343343
static const struct regmap_bus regmap_smbus_byte_word_reg16 = {

0 commit comments

Comments
 (0)