Skip to content

Commit 39436e1

Browse files
committed
Merge tag 'drm-misc-fixes-2026-04-30' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-fixes
Short summary of fixes pull: DRM core and helpers: - calculate framebuffer geometry with format helpers - fix docs appletbdrm: - allocate protocol buffers with kvzalloc() dma-buf: - fix docs imagination: - avoid segfault in debugfs ofdrm: - put PCI device reference on errors udl: - increase USB timeout Signed-off-by: Dave Airlie <airlied@redhat.com> From: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patch.msgid.link/20260430064521.GA14957@linux.fritz.box
2 parents 254f496 + ac2c996 commit 39436e1

10 files changed

Lines changed: 17 additions & 12 deletions

File tree

.mailmap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Abhinav Kumar <quic_abhinavk@quicinc.com> <abhinavk@codeaurora.org>
1919
Ahmad Masri <quic_amasri@quicinc.com> <amasri@codeaurora.org>
2020
Adam Oldham <oldhamca@gmail.com>
2121
Adam Radford <aradford@gmail.com>
22+
Aditya Garg <gargaditya08@proton.me> <gargaditya08@live.com>
2223
Adriana Reus <adi.reus@gmail.com> <adriana.reus@intel.com>
2324
Adrian Bunk <bunk@stusta.de>
2425
Ajay Kaher <ajay.kaher@broadcom.com> <akaher@vmware.com>

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7873,7 +7873,7 @@ F: drivers/gpu/drm/sun4i/sun8i*
78737873

78747874
DRM DRIVER FOR APPLE TOUCH BARS
78757875
M: Aun-Ali Zaidi <admin@kodeit.net>
7876-
M: Aditya Garg <gargaditya08@live.com>
7876+
M: Aditya Garg <gargaditya08@proton.me>
78777877
L: dri-devel@lists.freedesktop.org
78787878
S: Maintained
78797879
T: git https://gitlab.freedesktop.org/drm/misc/kernel.git

drivers/gpu/drm/drm_color_mgmt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ static void fill_palette_332(struct drm_crtc *crtc, u16 r, u16 g, u16 b,
831831
}
832832

833833
/**
834-
* drm_crtc_fill_palette_332 - Programs a default palette for R332-like formats
834+
* drm_crtc_fill_palette_332 - Programs a default palette for RGB332-like formats
835835
* @crtc: The displaying CRTC
836836
* @set_palette: Callback for programming the hardware gamma LUT
837837
*

drivers/gpu/drm/drm_gem_framebuffer_helper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
172172
}
173173

174174
for (i = 0; i < info->num_planes; i++) {
175-
unsigned int width = mode_cmd->width / (i ? info->hsub : 1);
176-
unsigned int height = mode_cmd->height / (i ? info->vsub : 1);
175+
unsigned int width = drm_format_info_plane_width(info, mode_cmd->width, i);
176+
unsigned int height = drm_format_info_plane_height(info, mode_cmd->height, i);
177177
unsigned int min_size;
178178

179179
objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);

drivers/gpu/drm/imagination/pvr_fw_trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,6 @@ pvr_fw_trace_debugfs_init(struct pvr_device *pvr_dev, struct dentry *dir)
558558
&pvr_fw_trace_fops);
559559
}
560560

561-
debugfs_create_file("trace_mask", 0600, dir, fw_trace,
561+
debugfs_create_file("trace_mask", 0600, dir, pvr_dev,
562562
&pvr_fw_trace_mask_fops);
563563
}

drivers/gpu/drm/sysfb/ofdrm.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ static void ofdrm_pci_release(void *data)
350350
struct pci_dev *pcidev = data;
351351

352352
pci_disable_device(pcidev);
353+
pci_dev_put(pcidev);
353354
}
354355

355356
static int ofdrm_device_init_pci(struct ofdrm_device *odev)
@@ -375,6 +376,7 @@ static int ofdrm_device_init_pci(struct ofdrm_device *odev)
375376
if (ret) {
376377
drm_err(dev, "pci_enable_device(%s) failed: %d\n",
377378
dev_name(&pcidev->dev), ret);
379+
pci_dev_put(pcidev);
378380
return ret;
379381
}
380382
ret = devm_add_action_or_reset(&pdev->dev, ofdrm_pci_release, pcidev);

drivers/gpu/drm/tiny/appletbdrm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ static int appletbdrm_primary_plane_helper_atomic_check(struct drm_plane *plane,
353353
frames_size +
354354
sizeof(struct appletbdrm_fb_request_footer), 16);
355355

356-
appletbdrm_state->request = kzalloc(request_size, GFP_KERNEL);
356+
appletbdrm_state->request = kvzalloc(request_size, GFP_KERNEL);
357357

358358
if (!appletbdrm_state->request)
359359
return -ENOMEM;
@@ -543,7 +543,7 @@ static void appletbdrm_primary_plane_destroy_state(struct drm_plane *plane,
543543
{
544544
struct appletbdrm_plane_state *appletbdrm_state = to_appletbdrm_plane_state(state);
545545

546-
kfree(appletbdrm_state->request);
546+
kvfree(appletbdrm_state->request);
547547
kfree(appletbdrm_state->response);
548548

549549
__drm_gem_destroy_shadow_plane_state(&appletbdrm_state->base);

drivers/gpu/drm/udl/udl_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,13 +285,12 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
285285
return unode->urb;
286286
}
287287

288-
#define GET_URB_TIMEOUT HZ
289288
struct urb *udl_get_urb(struct udl_device *udl)
290289
{
291290
struct urb *urb;
292291

293292
spin_lock_irq(&udl->urbs.lock);
294-
urb = udl_get_urb_locked(udl, GET_URB_TIMEOUT);
293+
urb = udl_get_urb_locked(udl, HZ * 2);
295294
spin_unlock_irq(&udl->urbs.lock);
296295
return urb;
297296
}

drivers/gpu/drm/udl/udl_modeset.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <drm/drm_gem_framebuffer_helper.h>
2222
#include <drm/drm_gem_shmem_helper.h>
2323
#include <drm/drm_modeset_helper_vtables.h>
24+
#include <drm/drm_print.h>
2425
#include <drm/drm_probe_helper.h>
2526
#include <drm/drm_vblank.h>
2627

@@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom
342343
return;
343344

344345
urb = udl_get_urb(udl);
345-
if (!urb)
346+
if (!urb) {
347+
drm_err_ratelimited(dev, "get urb failed when enabling crtc\n");
346348
goto out;
349+
}
347350

348351
buf = (char *)urb->transfer_buffer;
349352
buf = udl_vidreg_lock(buf);

include/linux/dma-buf.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,13 @@ struct dma_buf {
322322
* @vmapping_counter:
323323
*
324324
* Used internally to refcnt the vmaps returned by dma_buf_vmap().
325-
* Protected by @lock.
325+
* Protected by @resv.
326326
*/
327327
unsigned vmapping_counter;
328328

329329
/**
330330
* @vmap_ptr:
331-
* The current vmap ptr if @vmapping_counter > 0. Protected by @lock.
331+
* The current vmap ptr if @vmapping_counter > 0. Protected by @resv.
332332
*/
333333
struct iosys_map vmap_ptr;
334334

0 commit comments

Comments
 (0)