Skip to content

Commit 3f60354

Browse files
ujfalusiplbossart
authored andcommitted
ASoC: SOF: amd: Do not set ipc_pcm_params ops as it is optional
The ipc_pcm_params() ops implementation for AMD is a NOP and since the callback is marked now as optional, it can be dropped along with the empty function. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
1 parent b7baa43 commit 3f60354

3 files changed

Lines changed: 0 additions & 11 deletions

File tree

sound/soc/sof/amd/acp-ipc.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,6 @@ int acp_sof_ipc_msg_data(struct snd_sof_dev *sdev, struct snd_pcm_substream *sub
170170
}
171171
EXPORT_SYMBOL_NS(acp_sof_ipc_msg_data, SND_SOC_SOF_AMD_COMMON);
172172

173-
int acp_sof_ipc_pcm_params(struct snd_sof_dev *sdev, struct snd_pcm_substream *substream,
174-
const struct sof_ipc_pcm_params_reply *reply)
175-
{
176-
/* TODO: Implement stream hw params to validate stream offset */
177-
return 0;
178-
}
179-
EXPORT_SYMBOL_NS(acp_sof_ipc_pcm_params, SND_SOC_SOF_AMD_COMMON);
180-
181173
int acp_sof_ipc_get_mailbox_offset(struct snd_sof_dev *sdev)
182174
{
183175
return ACP_SCRATCH_MEMORY_ADDRESS;

sound/soc/sof/amd/acp.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,6 @@ int acp_sof_ipc_send_msg(struct snd_sof_dev *sdev,
185185
struct snd_sof_ipc_msg *msg);
186186
int acp_sof_ipc_get_mailbox_offset(struct snd_sof_dev *sdev);
187187
int acp_sof_ipc_get_window_offset(struct snd_sof_dev *sdev, u32 id);
188-
int acp_sof_ipc_pcm_params(struct snd_sof_dev *sdev, struct snd_pcm_substream *substream,
189-
const struct sof_ipc_pcm_params_reply *reply);
190188
void acp_mailbox_write(struct snd_sof_dev *sdev, u32 offset, void *message, size_t bytes);
191189
void acp_mailbox_read(struct snd_sof_dev *sdev, u32 offset, void *message, size_t bytes);
192190

sound/soc/sof/amd/renoir.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ const struct snd_sof_dsp_ops sof_renoir_ops = {
150150
/*IPC */
151151
.send_msg = acp_sof_ipc_send_msg,
152152
.ipc_msg_data = acp_sof_ipc_msg_data,
153-
.ipc_pcm_params = acp_sof_ipc_pcm_params,
154153
.get_mailbox_offset = acp_sof_ipc_get_mailbox_offset,
155154
.irq_thread = acp_sof_ipc_irq_thread,
156155
.fw_ready = sof_fw_ready,

0 commit comments

Comments
 (0)