Skip to content

Commit 521b0f2

Browse files
committed
ASoC: Intel: soc-acpi-intel-ptl-match: Remove unnecessary cs42l43 match
For PTL onwards Cirrus are intending to rely on function topologies, rather than using a match table for each system type. Remove this unnecessary match table entry. Having the match entries can mean that systems match when they should use function topologies instead, resulting in incorrect audio configurations. Although, admittedly this is not too likely with this 6x amp configuration as those are quite rare, but best to follow best practice. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
1 parent cd7e8dc commit 521b0f2

1 file changed

Lines changed: 0 additions & 118 deletions

File tree

sound/soc/intel/common/soc-acpi-intel-ptl-match.c

Lines changed: 0 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -92,48 +92,6 @@ static const struct snd_soc_acpi_endpoint spk_r_endpoint = {
9292
.group_id = 1,
9393
};
9494

95-
static const struct snd_soc_acpi_endpoint spk_1_endpoint = {
96-
.num = 0,
97-
.aggregated = 1,
98-
.group_position = 1,
99-
.group_id = 1,
100-
};
101-
102-
static const struct snd_soc_acpi_endpoint spk_2_endpoint = {
103-
.num = 0,
104-
.aggregated = 1,
105-
.group_position = 2,
106-
.group_id = 1,
107-
};
108-
109-
static const struct snd_soc_acpi_endpoint spk_3_endpoint = {
110-
.num = 0,
111-
.aggregated = 1,
112-
.group_position = 3,
113-
.group_id = 1,
114-
};
115-
116-
static const struct snd_soc_acpi_endpoint spk_4_endpoint = {
117-
.num = 0,
118-
.aggregated = 1,
119-
.group_position = 4,
120-
.group_id = 1,
121-
};
122-
123-
static const struct snd_soc_acpi_endpoint spk_5_endpoint = {
124-
.num = 0,
125-
.aggregated = 1,
126-
.group_position = 5,
127-
.group_id = 1,
128-
};
129-
130-
static const struct snd_soc_acpi_endpoint spk_6_endpoint = {
131-
.num = 0,
132-
.aggregated = 1,
133-
.group_position = 6,
134-
.group_id = 1,
135-
};
136-
13795
static const struct snd_soc_acpi_endpoint jack_dmic_endpoints[] = {
13896
/* Jack Endpoint */
13997
{
@@ -202,15 +160,6 @@ static const struct snd_soc_acpi_endpoint cs42l43_amp_spkagg_endpoints[] = {
202160
},
203161
};
204162

205-
static const struct snd_soc_acpi_adr_device cs42l43_2_adr[] = {
206-
{
207-
.adr = 0x00023001fa424301ull,
208-
.num_endpoints = ARRAY_SIZE(cs42l43_amp_spkagg_endpoints),
209-
.endpoints = cs42l43_amp_spkagg_endpoints,
210-
.name_prefix = "cs42l43"
211-
}
212-
};
213-
214163
static const struct snd_soc_acpi_adr_device cs42l43_3_agg_adr[] = {
215164
{
216165
.adr = 0x00033001FA424301ull,
@@ -235,48 +184,6 @@ static const struct snd_soc_acpi_adr_device cs35l56_2_lr_adr[] = {
235184
}
236185
};
237186

238-
static const struct snd_soc_acpi_adr_device cs35l56_1_3amp_adr[] = {
239-
{
240-
.adr = 0x00013001fa355601ull,
241-
.num_endpoints = 1,
242-
.endpoints = &spk_1_endpoint,
243-
.name_prefix = "AMP1"
244-
},
245-
{
246-
.adr = 0x00013101fa355601ull,
247-
.num_endpoints = 1,
248-
.endpoints = &spk_2_endpoint,
249-
.name_prefix = "AMP2"
250-
},
251-
{
252-
.adr = 0x00013201fa355601ull,
253-
.num_endpoints = 1,
254-
.endpoints = &spk_3_endpoint,
255-
.name_prefix = "AMP3"
256-
}
257-
};
258-
259-
static const struct snd_soc_acpi_adr_device cs35l56_3_3amp_adr[] = {
260-
{
261-
.adr = 0x00033301fa355601ull,
262-
.num_endpoints = 1,
263-
.endpoints = &spk_4_endpoint,
264-
.name_prefix = "AMP4"
265-
},
266-
{
267-
.adr = 0x00033401fa355601ull,
268-
.num_endpoints = 1,
269-
.endpoints = &spk_5_endpoint,
270-
.name_prefix = "AMP5"
271-
},
272-
{
273-
.adr = 0x00033501fa355601ull,
274-
.num_endpoints = 1,
275-
.endpoints = &spk_6_endpoint,
276-
.name_prefix = "AMP6"
277-
}
278-
};
279-
280187
static const struct snd_soc_acpi_adr_device rt711_sdca_0_adr[] = {
281188
{
282189
.adr = 0x000030025D071101ull,
@@ -408,25 +315,6 @@ static const struct snd_soc_acpi_link_adr ptl_cs42l43_agg_l3_cs35l56_l2[] = {
408315
{}
409316
};
410317

411-
static const struct snd_soc_acpi_link_adr ptl_cs42l43_l2_cs35l56x6_l13[] = {
412-
{
413-
.mask = BIT(2),
414-
.num_adr = ARRAY_SIZE(cs42l43_2_adr),
415-
.adr_d = cs42l43_2_adr,
416-
},
417-
{
418-
.mask = BIT(1),
419-
.num_adr = ARRAY_SIZE(cs35l56_1_3amp_adr),
420-
.adr_d = cs35l56_1_3amp_adr,
421-
},
422-
{
423-
.mask = BIT(3),
424-
.num_adr = ARRAY_SIZE(cs35l56_3_3amp_adr),
425-
.adr_d = cs35l56_3_3amp_adr,
426-
},
427-
{}
428-
};
429-
430318
static const struct snd_soc_acpi_link_adr ptl_rt722_l0_rt1320_l23[] = {
431319
{
432320
.mask = BIT(0),
@@ -578,12 +466,6 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_ptl_sdw_machines[] = {
578466
.sof_tplg_filename = "sof-ptl-rt713-l3-rt1320-l12.tplg",
579467
.get_function_tplg_files = sof_sdw_get_tplg_files,
580468
},
581-
{
582-
.link_mask = BIT(1) | BIT(2) | BIT(3),
583-
.links = ptl_cs42l43_l2_cs35l56x6_l13,
584-
.drv_name = "sof_sdw",
585-
.sof_tplg_filename = "sof-ptl-cs42l43-l2-cs35l56x6-l13.tplg",
586-
},
587469
{
588470
.link_mask = BIT(0) | BIT(2) | BIT(3),
589471
.links = ptl_rt722_l0_rt1320_l23,

0 commit comments

Comments
 (0)