Skip to content

Commit 52521e8

Browse files
committed
ALSA: usb-audio: Evaluate packsize caps at the right place
We introduced the upper bound checks of the packet sizes by the ep->maxframesize for avoiding the URB submission errors. However, the check was applied at an incorrect place in the function snd_usb_endpoint_set_params() where ep->maxframesize isn't defined yet; the value is defined at a bit later position. So this ended up with a failure at the first run while the second run works. For fixing it, move the check at the correct place, right after the calculation of ep->maxframesize in the same function. Fixes: 7fe8dec ("ALSA: usb-audio: Cap the packet size pre-calculations") Link: https://bugzilla.kernel.org/show_bug.cgi?id=221292 Cc: <stable@vger.kernel.org> Link: https://patch.msgid.link/20260410143220.1676344-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 00afb18 commit 52521e8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

sound/usb/endpoint.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1379,9 +1379,6 @@ int snd_usb_endpoint_set_params(struct snd_usb_audio *chip,
13791379
return -EINVAL;
13801380
}
13811381

1382-
ep->packsize[0] = min(ep->packsize[0], ep->maxframesize);
1383-
ep->packsize[1] = min(ep->packsize[1], ep->maxframesize);
1384-
13851382
/* calculate the frequency in 16.16 format */
13861383
ep->freqm = ep->freqn;
13871384
ep->freqshift = INT_MIN;
@@ -1408,6 +1405,9 @@ int snd_usb_endpoint_set_params(struct snd_usb_audio *chip,
14081405
ep->maxframesize = ep->maxpacksize / ep->cur_frame_bytes;
14091406
ep->curframesize = ep->curpacksize / ep->cur_frame_bytes;
14101407

1408+
ep->packsize[0] = min(ep->packsize[0], ep->maxframesize);
1409+
ep->packsize[1] = min(ep->packsize[1], ep->maxframesize);
1410+
14111411
err = update_clock_ref_rate(chip, ep);
14121412
if (err >= 0) {
14131413
ep->need_setup = false;

0 commit comments

Comments
 (0)