Skip to content

Commit 5363b67

Browse files
Xianwei ZhaoThomas Gleixner
authored andcommitted
irqchip/meson-gpio: Use the correct register in meson_s4_gpio_irq_set_type()
meson_s4_gpio_irq_set_type() uses the both-edge trigger register for configuring level type and single edge mode interrupts, which is not correct. Use REG_EDGE_POL instead. Fixes: bbd6fcc ("irqchip: Add support for Amlogic A4 and A5 SoCs") Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260508-a9-gpio-irqchip-v1-1-9dc5f3e022e0@amlogic.com
1 parent 0fa10fb commit 5363b67

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/irqchip/irq-meson-gpio.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,7 @@ static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl,
415415
if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
416416
val |= BIT(ctl->params->edge_single_offset + idx);
417417

418-
meson_gpio_irq_update_bits(ctl, params->edge_pol_reg,
419-
BIT(idx) | BIT(12 + idx), val);
418+
meson_gpio_irq_update_bits(ctl, REG_EDGE_POL, BIT(idx) | BIT(12 + idx), val);
420419
return 0;
421420
};
422421

0 commit comments

Comments
 (0)