Skip to content

Commit 53705dd

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: pm: restrict 'unknown' check to pm_nl_ctl
When pm_netlink.sh is executed with '-i', 'ip mptcp' is used instead of 'pm_nl_ctl'. IPRoute2 doesn't support the 'unknown' flag, which has only been added to 'pm_nl_ctl' for this specific check: to ensure that the kernel ignores such unsupported flag. No reason to add this flag to 'ip mptcp'. Then, this check should be skipped when 'ip mptcp' is used. Fixes: 0cef6fc ("selftests: mptcp: ip_mptcp option for more scripts") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20260505-net-mptcp-pm-fixes-7-1-rc3-v1-11-fca8091060a4@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 65db7b2 commit 53705dd

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

tools/testing/selftests/net/mptcp/pm_netlink.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,13 @@ check "show_endpoints" \
194194
flush_endpoint
195195
check "show_endpoints" "" "flush addrs"
196196

197-
add_endpoint 10.0.1.1 flags unknown
198-
check "show_endpoints" "$(format_endpoints "1,10.0.1.1")" "ignore unknown flags"
199-
flush_endpoint
197+
# "unknown" flag is only supported by pm_nl_ctl
198+
if ! mptcp_lib_is_ip_mptcp; then
199+
add_endpoint 10.0.1.1 flags unknown
200+
check "show_endpoints" "$(format_endpoints "1,10.0.1.1")" \
201+
"ignore unknown flags"
202+
flush_endpoint
203+
fi
200204

201205
set_limits 9 1 2>/dev/null
202206
check "get_limits" "${default_limits}" "rcv addrs above hard limit"

0 commit comments

Comments
 (0)