ASoC: SOF: Intel: hda: clarify operator precedence

plbossart · plbossart · commit 65878421f7ec · 2021-12-09T09:43:05.000-06:00
cppcheck warning

sound/soc/sof/intel/hda.c:545:46: style: Clarify calculation
precedence for '&amp;' and '?'. [clarifyCalculation]
 char *level = flags &amp; SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;

Signed-off-by: Pierre-Louis Bossart &lt;pierre-louis.bossart@linux.intel.com&gt;
diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
@@ -534,7 +534,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, const char *le
 
 void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags)
 {
-	char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
+	char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;
 	struct sof_ipc_dsp_oops_xtensa xoops;
 	struct sof_ipc_panic_info panic_info;
 	u32 stack[HDA_DSP_STACK_DUMP_SIZE];

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev sdev, const char le`
`534`	`534`
`535`	`535`	`void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags)`
`536`	`536`	`{`
`537`		`- char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;`
	`537`	`+ char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;`
`538`	`538`	`struct sof_ipc_dsp_oops_xtensa xoops;`
`539`	`539`	`struct sof_ipc_panic_info panic_info;`
`540`	`540`	`u32 stack[HDA_DSP_STACK_DUMP_SIZE];`