USB: core: ratelimit cabling message

oneukum · gregkh · commit 6df47500b557 · 2026-07-08T17:19:17.000+02:00
If a cable is bad, it stays bad. There is no need to flood the log with messages about it. So go for a ratelimited version. Signed-off-by: Oliver Neukum <oneukum@suse.com> Link: https://patch.msgid.link/20260605090110.1514785-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
@@ -3148,7 +3148,7 @@ static int hub_port_reset(struct usb_hub *hub, int port1,
 		delay = HUB_LONG_RESET_TIME;
 	}
 
-	dev_err(&port_dev->dev, "Cannot enable. Maybe the USB cable is bad?\n");
+	dev_err_ratelimited(&port_dev->dev, "Cannot enable. Maybe the USB cable is bad?\n");
 
 done:
 	if (status == 0) {

Original file line number	Diff line number	Diff line change
`@@ -3148,7 +3148,7 @@ static int hub_port_reset(struct usb_hub *hub, int port1,`
`3148`	`3148`	`delay = HUB_LONG_RESET_TIME;`
`3149`	`3149`	`}`
`3150`	`3150`
`3151`		`- dev_err(&port_dev->dev, "Cannot enable. Maybe the USB cable is bad?\n");`
	`3151`	`+ dev_err_ratelimited(&port_dev->dev, "Cannot enable. Maybe the USB cable is bad?\n");`
`3152`	`3152`
`3153`	`3153`	`done:`
`3154`	`3154`	`if (status == 0) {`