Skip to content

Commit 6facd84

Browse files
zhaoxiaothierryreding
authored andcommitted
pwm: visconti: Simplify using devm_pwmchip_add()
This allows to drop the platform_driver's remove function. This is the only user of driver data so this can go away, too. Signed-off-by: zhaoxiao <long870912@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent 06dfae3 commit 6facd84

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

drivers/pwm/pwm-visconti.c

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -144,28 +144,17 @@ static int visconti_pwm_probe(struct platform_device *pdev)
144144
if (IS_ERR(priv->base))
145145
return PTR_ERR(priv->base);
146146

147-
platform_set_drvdata(pdev, priv);
148-
149147
priv->chip.dev = dev;
150148
priv->chip.ops = &visconti_pwm_ops;
151149
priv->chip.npwm = 4;
152150

153-
ret = pwmchip_add(&priv->chip);
151+
ret = devm_pwmchip_add(&pdev->dev, &priv->chip);
154152
if (ret < 0)
155153
return dev_err_probe(&pdev->dev, ret, "Cannot register visconti PWM\n");
156154

157155
return 0;
158156
}
159157

160-
static int visconti_pwm_remove(struct platform_device *pdev)
161-
{
162-
struct visconti_pwm_chip *priv = platform_get_drvdata(pdev);
163-
164-
pwmchip_remove(&priv->chip);
165-
166-
return 0;
167-
}
168-
169158
static const struct of_device_id visconti_pwm_of_match[] = {
170159
{ .compatible = "toshiba,visconti-pwm", },
171160
{ }
@@ -178,7 +167,6 @@ static struct platform_driver visconti_pwm_driver = {
178167
.of_match_table = visconti_pwm_of_match,
179168
},
180169
.probe = visconti_pwm_probe,
181-
.remove = visconti_pwm_remove,
182170
};
183171
module_platform_driver(visconti_pwm_driver);
184172

0 commit comments

Comments
 (0)