Skip to content

Commit 701ea57

Browse files
Shitalkumar Gandhikuba-moo
authored andcommitted
net: rtsn: fix mdio_node leak in rtsn_mdio_alloc()
of_get_child_by_name() takes a reference. The rtsn_reset() and rtsn_change_mode() failure paths jump to out_free_bus and leak mdio_node. Add out_put_node to drop it before falling through. Fixes: b0d3969 ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Link: https://patch.msgid.link/20260505123236.406000-1-shitalkumar.gandhi@cambiumnetworks.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e418273 commit 701ea57

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • drivers/net/ethernet/renesas

drivers/net/ethernet/renesas/rtsn.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -797,11 +797,11 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv)
797797
/* Enter config mode before registering the MDIO bus */
798798
ret = rtsn_reset(priv);
799799
if (ret)
800-
goto out_free_bus;
800+
goto out_put_node;
801801

802802
ret = rtsn_change_mode(priv, OCR_OPC_CONFIG);
803803
if (ret)
804-
goto out_free_bus;
804+
goto out_put_node;
805805

806806
rtsn_modify(priv, MPIC, MPIC_PSMCS_MASK | MPIC_PSMHT_MASK,
807807
MPIC_PSMCS_DEFAULT | MPIC_PSMHT_DEFAULT);
@@ -824,6 +824,8 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv)
824824

825825
return 0;
826826

827+
out_put_node:
828+
of_node_put(mdio_node);
827829
out_free_bus:
828830
mdiobus_free(mii);
829831
return ret;

0 commit comments

Comments
 (0)