Skip to content

Commit 7643978

Browse files
john-madieubroonie
authored andcommitted
spi: rockchip: Drop unused and broken CR0 macros
Two CTRLR0 macros are defined but never referenced, and both are wrong: - CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere in the tree. The intended symbol is CR0_XFM_OFFSET. - CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register. The value is meaningless and the macro is unused. Drop both. They can be re-introduced correctly when an actual user appears. Signed-off-by: John Madieu <john.madieu@gmail.com> Link: https://patch.msgid.link/20260425092936.2590132-3-john.madieu@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent b4683a2 commit 7643978

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/spi/spi-rockchip.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@
9898
#define CR0_FRF_MICROWIRE 0x2
9999

100100
#define CR0_XFM_OFFSET 18
101-
#define CR0_XFM_MASK (0x03 << SPI_XFM_OFFSET)
102101
#define CR0_XFM_TR 0x0
103102
#define CR0_XFM_TO 0x1
104103
#define CR0_XFM_RO 0x2
@@ -109,8 +108,6 @@
109108

110109
#define CR0_SOI_OFFSET 23
111110

112-
#define CR0_MTM_OFFSET 0x21
113-
114111
/* Bit fields in SER, 2bit */
115112
#define SER_MASK 0x3
116113

0 commit comments

Comments
 (0)