ASoC: SOF: sof-audio: Fix error path in sof_widget_setup_unlocked()

If either tplg_ops->dai_config or widget_kcontrol_setup fail during widget
setup we would double decrement the use_count of the widget because the
sof_widget_free_unlocked() would be called twice, similarly the core_put
would be invoked twice as well.

The code between pipe_widget_free and use_count_dec is done within
sof_widget_free_unlocked() and we need to skip it during error handling.

The fixes tag is picked to the last change around this part of the code
which is adequately old enough for backporting purposes.

Link: thesofproject/sof#10826
Fixes: 31ed8da ("ASoC: SOF: sof-audio: Modify logic for enabling/disabling topology cores")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Author: ujfalusi

sound/soc/sof/sof-audio.c

@@ -228,6 +228,8 @@ static int sof_widget_setup_unlocked(struct snd_sof_dev *sdev,
 	/* widget use_count will be decremented by sof_widget_free() */
 	sof_widget_free_unlocked(sdev, swidget);
 	use_count_decremented = true;
+	/* sof_widget_free_unlocked already cleaned up pipe_widget/cores */
+	goto use_count_dec;
 pipe_widget_free:
 	if (swidget->id != snd_soc_dapm_scheduler) {
 		sof_widget_free_unlocked(sdev, swidget->spipe->pipe_widget);